Skip to content

Conversation

@Bill-hbrhbr
Copy link
Collaborator

@Bill-hbrhbr Bill-hbrhbr commented Feb 4, 2025

Description

As the title says:

  • Use absolute paths for lint-requirements.txt. Changes to this file was not picked up by the task lint:venv.
  • Move lint-venv to a standalone file to avoid recreating venv unnecessarily due to unrelated changes to taskfiles/lint.yaml
  • Rename G_YSTDLIB_CPP_SRC_DIR to G_CPP_SRC_DIR and update the path from src/ystdlib to src for broader C++ source file coverage.

Other minor changes:

  • Reorder alias and desc
  • Remove unnecessary gersemi config source from lint:cmake-check/fix

Validation performed

  • Tested locally that all changes have taken effects.

@Bill-hbrhbr Bill-hbrhbr changed the title fix: fix: Use absolute paths for lint-requirements.txt; Optimize lint:venv execution; Improve variable naming and ordering. Feb 4, 2025
@Bill-hbrhbr Bill-hbrhbr requested a review from davidlion February 4, 2025 13:49
@Bill-hbrhbr Bill-hbrhbr marked this pull request as ready for review February 4, 2025 13:49
@davidlion davidlion changed the title fix: Use absolute paths for lint-requirements.txt; Optimize lint:venv execution; Improve variable naming and ordering. fix: Specify correct source path for lint-requirements.txt; Prevent lint:venv from running unnecessarily. Feb 5, 2025
@davidlion davidlion changed the title fix: Specify correct source path for lint-requirements.txt; Prevent lint:venv from running unnecessarily. fix: Specify correct source path for lint-requirements.txt; Prevent lint:venv from running unnecessarily. Feb 5, 2025
@davidlion davidlion merged commit 8ab8a1e into y-scope:main Feb 5, 2025
11 of 12 checks passed
@Bill-hbrhbr Bill-hbrhbr deleted the fix-lint-files branch February 20, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants