build(deps): Bump yscope-dev-utils to the newest version.
#73
Conversation
WalkthroughRelocates the Catch2 Catch.cmake path in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (3)
.gersemirc(1 hunks).gitignore(1 hunks)tools/yscope-dev-utils(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: Bill-hbrhbr
PR: y-scope/ystdlib-cpp#32
File: CMakeLists.txt:0-0
Timestamp: 2025-02-28T05:04:33.616Z
Learning: Bill-hbrhbr uses a maximum line length of 100 characters in CMake files and prefers to use backslash line continuations to maintain this limit.
📚 Learning: 2025-03-06T20:42:41.772Z
Learnt from: Bill-hbrhbr
PR: y-scope/ystdlib-cpp#0
File: :0-0
Timestamp: 2025-03-06T20:42:41.772Z
Learning: In the y-scope/ystdlib-cpp project, the linting scope is limited to .h, .hpp, and .cpp files, and the header-only detection logic in CMake checks for .h, .hpp, and .inc extensions.
Applied to files:
.gitignore
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: build-ystdlib-cpp (ubuntu-24.04, debug)
- GitHub Check: build-ystdlib-cpp (ubuntu-24.04, release)
- GitHub Check: build-ystdlib-cpp (macos-14, release)
- GitHub Check: build-ystdlib-cpp (ubuntu-22.04, release)
- GitHub Check: build-ystdlib-cpp (ubuntu-22.04, debug)
- GitHub Check: build-ystdlib-cpp (macos-15, release)
- GitHub Check: build-ystdlib-cpp (macos-15, debug)
- GitHub Check: build-ystdlib-cpp (macos-14, debug)
- GitHub Check: lint-check (macos-15)
- GitHub Check: lint-check (ubuntu-24.04)
🔇 Additional comments (2)
tools/yscope-dev-utils (1)
1-1: Submodule pointer bump looks goodThe pointer update to e121a57… is straightforward. No API or runtime impact within this repo. CI passing is sufficient signal for this change.
.gersemirc (1)
6-6: Add fallback Catch2 path in .gersemircTo support both bootstrap flows (where Catch2 may be placed under
Catch2-extractedor underCatch2-src), include both paths in thedefinitionsarray. Gersemi will pick up whichever file exists; please verify it ignores the missing entry without error.In
.gersemirc(around line 6):definitions: - - "cmake/ystdlib-helpers.cmake" - - "build/deps/Catch2-extracted/extras/Catch.cmake" + - "cmake/ystdlib-helpers.cmake" + - "build/deps/Catch2-extracted/extras/Catch.cmake" + - "build/deps/Catch2-src/extras/Catch.cmake"
…clang-tidy/format
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
.gitignore(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: Bill-hbrhbr
PR: y-scope/ystdlib-cpp#32
File: CMakeLists.txt:0-0
Timestamp: 2025-02-28T05:04:33.616Z
Learning: Bill-hbrhbr uses a maximum line length of 100 characters in CMake files and prefers to use backslash line continuations to maintain this limit.
📚 Learning: 2025-03-06T20:42:41.772Z
Learnt from: Bill-hbrhbr
PR: y-scope/ystdlib-cpp#0
File: :0-0
Timestamp: 2025-03-06T20:42:41.772Z
Learning: In the y-scope/ystdlib-cpp project, the linting scope is limited to .h, .hpp, and .cpp files, and the header-only detection logic in CMake checks for .h, .hpp, and .inc extensions.
Applied to files:
.gitignore
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: build-ystdlib-cpp (ubuntu-22.04, release)
- GitHub Check: build-ystdlib-cpp (macos-14, debug)
- GitHub Check: build-ystdlib-cpp (ubuntu-22.04, debug)
- GitHub Check: build-ystdlib-cpp (ubuntu-24.04, debug)
- GitHub Check: build-ystdlib-cpp (ubuntu-24.04, release)
- GitHub Check: build-ystdlib-cpp (macos-15, release)
- GitHub Check: build-ystdlib-cpp (macos-14, release)
- GitHub Check: build-ystdlib-cpp (macos-15, debug)
- GitHub Check: lint-check (macos-15)
- GitHub Check: lint-check (ubuntu-24.04)
🔇 Additional comments (2)
.gitignore (2)
8-10: Anchored ignore patterns LGTM; this aligns with best practice and prior feedbackUsing "/.clang-format" and "/.clang-tidy" confines the ignore to the repo root, preserving any nested, project-scoped configs under version control. No further action needed here.
8-10: All set: .clang-format and .clang-tidy are untracked
The new.gitignoreentries will now prevent these files from being added to the index.
| # Lint config files | ||
| /.clang-format | ||
| /.clang-tidy |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Optional: Add ignores for local override files to support per-developer tweaks
If you want to allow local overrides without affecting CI or shared formatting, consider ignoring conventional local variants.
# Lint config files
/.clang-format
/.clang-tidy
+/.clang-format.local
+/.clang-tidy.local📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # Lint config files | |
| /.clang-format | |
| /.clang-tidy | |
| # Lint config files | |
| /.clang-format | |
| /.clang-tidy | |
| /.clang-format.local | |
| /.clang-tidy.local |
🤖 Prompt for AI Agents
In .gitignore around lines 8 to 10, add ignores for per-developer local override
files so developers can keep local tweaks out of commits; append entries such as
"/.clang-format.local" and "/.clang-tidy.local" (or a single pattern like
"/.clang-format.*" and "/.clang-tidy.*" if you want to cover other variants) to
the file and commit the change.
2 participants
Description
As title.
Checklist
breaking change.
Validation performed
Summary by CodeRabbit