Conversation
- Extract the "getting" logic in `setBladeComments` method into a new `getBladeOrHtmlComments` method. This removes confusion about what the function does. It was doing too many things. It now adheres to the DOT principle.
- The `getBladeOrHtmlComments` method now only returns the blade/html comments.
- The `setBladeComments` method now only sets the comments configuration for the blade language. It also uses the new `getBladeOrHtmlComments`.
- Changed the `setBladeComments` call to use the new `getBladeOrHtmlComments` method in `setLanguageConfiguration`.
…lper - Refactor the custom single-line language logic in `setSingleLineCommentLanguageDefinitions` method to replace the duplicate loops and logic by a single new helper method: `addCustomSingleLineLanguages`.
Merged
yCodeTech
pushed a commit
that referenced
this pull request
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted the logic for determining the appropriate Blade or HTML comment style into a new private method
getBladeOrHtmlComments, simplifying the public API and improving clarity. ThesetBladeCommentsmethod now only sets the configuration and no longer returns values based on anonStartflag (the flag was removed in favour using the new private method directly).Replaced repetitive code for adding custom single-line comment languages with a new private method
addCustomSingleLineLanguages, reducing duplication and improving maintainability.Replaced
varwithletfor variable declarations in several places to align with modern best practices.