-
Notifications
You must be signed in to change notification settings - Fork 10
v2.0.5 Pre-release 2 - Additions, Fixtures and Changes #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed a bug that inconsistently and inaccurately calculates the width of the timeline on init, so the scrolling of the timeline was off slightly. (This was due to the function being called slightly before all elements had to chance to be created). Fixed with a 300s delay. - Added a proper getMonthName function to make it easier.
Upon adding the useFontAwesomeIcons option, I forgot to add an if statement around the css file. Line 89.
Fixed a bug that when no buttons are rendered/added, then the timeline appears not to have a width for some reason, (added min-width) line 57.
Fixed a bug where the timeline would apparently have no width when the buttons are disabled. Line 221.
Removed previous bug fix min-width due to it actually not working. Fixed with JS instead.
Fixed a bug that shows the horizontal (x) scrollbar when translating the event content, added a overflow-x: hidden to stop this. Line 18.
Fixed a bug where if the content was swiped and then another timeline's nav buttons were clicked, the nav buttons would sync up to the first timeline instead, breaking the whole timeline system. (Added on lines 574 and 591.)
Fixed a bug to do with the scrollbar, Line 13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.