Update to Sage v10.8.2 and PHP 8.2 #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…espectively. Also auto formatting.
…ty footer element
…ndles during initial development.
…e it's a private package.
The `config()` method of `Application` doesn't exist in the current Acorn (v4.3.1) and this new bootloader code is not apart of Sage v10.8.2, but for an upcoming version of Sage. Fixes PHP error: "Fatal error: Uncaught BadMethodCallException: Method Roots\Acorn\Application::configure does not exist." by reverting the code changed in commit a0d1856.
The commit a95985f removed the declaration of the `ThemeServiceProvider`. This is not needed for an upcoming version of Sage, but is needed for Sage 10.8.2. Fixes PHP/Symfony error: "Target class [sage.view] does not exist." by re-adding the declaration of `ThemeServiceProvider` in composer.json. Related to commit 8a9c7c2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update code to reflect that of Sage v10.8.2 and require PHP 8.2
Added
app/View/Composers/Comments.php.Changed
.editorconfigto use tabs instead of spaces..gitignoreto remove unnecessary entries.LICENSE.mdcopyright information.README.mdbadges and instructions.stylesandscriptstocssandjsinapp/setup.php.composer.jsonto require PHP version 8.2 or higher.style.cssand bumped PHP version.app/View/Composers/Post.phpto add pagination functionality.Removed
app/View/Components/Alert.php.jsconfig.config/assets.php.node-sass-glob-importerdependency.Fixed
wp_link_pagespagination check to prevent rendering an empty footer element.For more details, please refer to the pull request commits.