Skip to content

remove: redundant fastcgi intercept error directives from site config stubs#39

Merged
yCodeTech merged 1 commit intomasterfrom
refactor/remove-site-conf-fastcgi-intercept-errors-directives
Apr 3, 2026
Merged

remove: redundant fastcgi intercept error directives from site config stubs#39
yCodeTech merged 1 commit intomasterfrom
refactor/remove-site-conf-fastcgi-intercept-errors-directives

Conversation

@yCodeTech
Copy link
Copy Markdown
Owner

@yCodeTech yCodeTech commented Apr 3, 2026

The fastcgi_intercept_errors and error_page directives that were added in #26 are redundant in the site configs, they are not used by nginx. It is only the main valet.conf that nginx uses these directives from, all others are ignored in sites configs. Also the proxy_intercept_errors directive is not needed either since the fastcgi_intercept_errors directive will also do the same job for proxied sites.

  • Removed proxy_intercept_errors on; and fastcgi_intercept_errors on; directives from all proxy and fastcgi locations in the nginx stubs: proxy.valet.conf, secure.proxy.valet.conf, secure.valet.conf, and unsecure.valet.conf.
  • Deleted the custom error page configuration for HTTP 500, 502, 503, and 504 errors, including the internal /500.html location and references to VALET_ERROR_TEMPLATE_PATH, from all affected configuration stubs.

@yCodeTech yCodeTech added the enhancement A quality of life enhancement label Apr 3, 2026
@yCodeTech yCodeTech merged commit 8b83537 into master Apr 3, 2026
@yCodeTech yCodeTech deleted the refactor/remove-site-conf-fastcgi-intercept-errors-directives branch April 3, 2026 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement A quality of life enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant