Wrong function numbers are used#108
Open
douweyntema wants to merge 1 commit into
Open
Conversation
The constants used for the function numbers are wrong. I corrected them, now it is working
Owner
|
@douweyntema thank you for the PR, i have concerns about this change, the original desight call for using CB_ callback indexes and not the FC_ function call codes ... maybe the issue is in a different place in the code ? |
Author
|
Hello,I made a program based on your multi example. The communication was not working.I changed the CB to FB and then it worked immediately.If I understand the callback function needs a parameter with the requested modbus function number.This is defined in the FC constant.Cheers,DouweOp 13 mei 2026 18:01 schreef Yaacov Zamir ***@***.***>:yaacov left a comment (yaacov/ArduinoModbusSlave#108)
@douweyntema thank you for the PR, i have concerns about this change, the original desight call for using CB_ callback indexes and not the FC_ function call codes ... maybe the issue is in a different place in the code ?
—Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The constants used for the function numbers are wrong.
I corrected them, now it is working