Skip to content

Invalid resource error handling#146

Merged
lingyan merged 2 commits intoyahoo:masterfrom
narkq:invalid-resource-error-handling
May 18, 2016
Merged

Invalid resource error handling#146
lingyan merged 2 commits intoyahoo:masterfrom
narkq:invalid-resource-error-handling

Conversation

@narkq
Copy link
Contributor

@narkq narkq commented May 18, 2016

In a server-side fetcher, there is currently no way to handle any error that's thrown by Fetcher.getService (since it gets executed via setImmediate inside of a promise constructor).
In particular, if you specify an invalid resource name (and that's easy to do for the new people on team in a substantially complex app), an error ends up in uncaughtException handler (or crashes the server).

@yahoocla
Copy link

CLA is valid!

@mridgway mridgway added the ready label May 18, 2016
@coveralls
Copy link

coveralls commented May 18, 2016

Coverage Status

Coverage increased (+0.02%) to 97.204% when pulling b37b8ab on narkq:invalid-resource-error-handling into 55d520f on yahoo:master.

@lingyan
Copy link
Member

lingyan commented May 18, 2016

👍

1 similar comment
@redonkulus
Copy link
Collaborator

👍

@lingyan lingyan merged commit bd477c3 into yahoo:master May 18, 2016
@lingyan lingyan removed the ready label May 18, 2016
@lingyan
Copy link
Member

lingyan commented May 19, 2016

Thanks @narkq for your contribution!
New release has been published with your fix: https://github.com/yahoo/fetchr/releases/tag/v0.5.30

@narkq narkq deleted the invalid-resource-error-handling branch May 24, 2016 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants