Reworks role based resource validation.#1288
Merged
Conversation
-- We fully generalize RoleBasedTableValidatorRequestMapper to apply to any ApiRequest, not just DataApiRequest, and in the process, rename it to `RoleBasedValidatorRequestMapper` since it no longer necessarily involves tables. -- RoleBasedTableValidatorRequestMapper becomes a subclass of `RoleBasedValidatorRequestMapper` specifically for TableApiRequests. The subclass delegates to its parent if the request contains a table (i.e. the user requests information about a specific table). Otherwise, if there is no table on the request (i.e. the user asks for information about all tables), the `RoleBasedTableValidatorRequestMapper` instead modifies the TableApiRequest to only expose those tables that pass validation.
archolewa
force-pushed
the
generalize-roles-table-mapepr
branch
from
6671a36 to
dbe4ec9
Compare
michael-mclawhorn
approved these changes
Dec 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-- We fully generalize RoleBasedTableValidatorRequestMapper to apply to any ApiRequest, not just DataApiRequest, and in the process, rename it to
RoleBasedValidatorRequestMappersince it no longer necessarily involves tables.-- RoleBasedTableValidatorRequestMapper becomes a subclass of
RoleBasedValidatorRequestMapperspecifically for TableApiRequests. The subclass delegates to its parent if the request contains a table (i.e. the user requests information about a specific table). Otherwise, if there is no table on the request (i.e. the user asks for information about all tables), theRoleBasedTableValidatorRequestMapperinstead modifies the TableApiRequest to only expose those tables that pass validation.I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.