Avoid YAML parse segfault on bad transactions#347
Merged
bneradt merged 1 commit intoyahoo:masterfrom Mar 12, 2026
Merged
Conversation
Stop replay parsing from running transaction callbacks after txn_open fails. That keeps malformed replay files from reaching txn_close with invalid transaction state. Also validate server transactions before taking the load mutex and add a unit test that covers the failed-open path. Fixes: yahoo#291
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop replay parsing from running transaction callbacks after txn_open
fails. That keeps malformed replay files from reaching txn_close with
invalid transaction state.
Also validate server transactions before taking the load mutex and add
a unit test that covers the failed-open path.
Fixes: #291