Fix repeated field verification#350
Merged
bneradt merged 1 commit intoyahoo:masterfrom Mar 13, 2026
Merged
Conversation
bneradt
force-pushed
the
fix-repeated-field-verification
branch
3 times, most recently
from
deaf06d to
43191f4
Compare
Make repeated non-Set-Cookie fields verify the RFC 9110 semantics by combining repeated field lines with comma SP in receive order before running the configured rule. Handle Set-Cookie through its dedicated verification path, matching individual cookie lines without forcing a specific order, and refresh the docs and regression tests to describe that split clearly. Fixes: yahoo#309
bneradt
force-pushed
the
fix-repeated-field-verification
branch
from
43191f4 to
c558ccb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make repeated non-Set-Cookie fields verify the RFC 9110 semantics by
combining repeated field lines with comma SP in receive order before
running the configured rule.
Handle Set-Cookie through its dedicated verification path, matching
individual cookie lines without forcing a specific order, and refresh
the docs and regression tests to describe that split clearly.
Fixes: #309