Conversation
Collaborator
|
👍 |
|
CLA is valid! |
Member
|
🚢 |
Contributor
Author
|
just added coverage check, and it's too low, while I'm doing some refactoring for unit test, let me merge this first and have another PR for unit test/coverage |
kaesonho
added a commit
that referenced
this pull request
Sep 9, 2015
check hidden nodes when creating debug dashboards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@redonkulus @lingyan @hankhsiao
An enhancement for the debug tool, previously we created a node for every i13nNode, even though it's not shown.
this PR use
window.getComputedStyleand check parent recursively. that takes some time but only happens when users enable the debug mode.