Add reset to column search and icons to copy and colvis buttons #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We also have discussed this internally, resetting the column search way back but wasn't able to implement/release it. Thanks for the PR ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured it would make sense for the
resetbutton to also reset column based searches. Column based search is not yet supported by your package by default, but I guess this could be implemented if necessary. Currently I'm using it for a project and it was rather diffcult to hook into the reset to clear the additional settings. Anyhow, if no column filters are present, it won't hurt - if there are, people will understand my request.Second change is an addition of button icons for the
copyHtml5andcolvisbuttons. ThecopyHtml5button will be displayed if thecopybutton is asked for in the datatables config. I added this addition in a way so that it does not change the actual implementation given by datatables.net as this would be rather inconvenient due to the size of some functions. It simply overrides the text property, nothing more.