Skip to content

Fix hard to see colors#890

Merged
yamcodes merged 4 commits intomainfrom
fix-hard-to-see-colors
May 2, 2026
Merged

Fix hard to see colors#890
yamcodes merged 4 commits intomainfrom
fix-hard-to-see-colors

Conversation

@yamcodes
Copy link
Copy Markdown
Owner

@yamcodes yamcodes commented May 2, 2026

Summary by CodeRabbit

  • Style
    • Refined color palette with updated primary colors in both light and dark themes.
    • Adjusted text contrast in light theme for improved readability.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 2, 2026

⚠️ No Changeset found

Latest commit: b5acd3a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 2, 2026

Warning

Rate limit exceeded

@yamcodes has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 55 minutes and 40 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c4e7f319-dd41-4ea0-afee-d83e48401b76

📥 Commits

Reviewing files that changed from the base of the PR and between 1f9f6a0 and b5acd3a.

📒 Files selected for processing (2)
  • .idea/vcs.xml
  • apps/www/app/styles/theme/light.css

Walkthrough

This PR updates IDE configuration to resolve GitHub issue links to a new repository and adds primary color theme variables to both light and dark CSS theme files.

Changes

IDE Configuration Update

Layer / File(s) Summary
Issue Link Configuration
.idea/vcs.xml
GitHub issue navigation links are updated to point from old repositories (danciudev/arkenv, yamcodes/arkenv, arktypeio/arktype) to aruaycodes/arkenv for patterns #(\d+), GH-(\d+), and \(#(\d+)\).

Theme Color Variables

Layer / File(s) Summary
Light Theme Colors
apps/www/app/styles/theme/light.css
CSS custom properties updated: --primary changes to #1e40af, --muted-foreground adjusted from hsl(240 4% 40%) to hsl(240 4% 55%) with WCAG comment removed. New variables --fd-primary and --color-fd-primary added with value #1e40af.
Dark Theme Colors
apps/www/app/styles/theme/dark.css
CSS custom properties added: --fd-primary and --color-fd-primary both set to rgb(158, 203, 255) in the .dark selector.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Possibly related PRs

Poem

🐰 In shades of blue, the palette grows,
New primary hues in soft light flows,
Dark themes dance with RGB's glow,
Issue links now find their home—
A colorful tale, from root to roam! 🎨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix hard to see colors' directly describes the primary changes across all modified files: adding new CSS color variables and updating existing ones for improved visibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-hard-to-see-colors

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 55 minutes and 40 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@yamcodes yamcodes marked this pull request as ready for review May 2, 2026 08:32
@github-actions github-actions Bot added the www Improvements or additions to arkenv.js.org label May 2, 2026
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
apps/www/app/styles/theme/light.css (1)

10-11: ⚡ Quick win

Prefer aliasing FD primary tokens to avoid future drift.

These values duplicate --primary literally. Referencing the primary token directly keeps theme updates consistent.

Suggested refactor
-	--fd-primary: `#1e40af`;
-	--color-fd-primary: `#1e40af`;
+	--fd-primary: var(--primary);
+	--color-fd-primary: var(--fd-primary);
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@apps/www/app/styles/theme/light.css` around lines 10 - 11, The CSS defines
--fd-primary and --color-fd-primary as duplicate hex values which can drift from
the main --primary; change both --fd-primary and --color-fd-primary to alias the
canonical token by setting them to var(--primary) so they always inherit updates
from --primary (update the declarations for --fd-primary and --color-fd-primary
to reference var(--primary)).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.idea/vcs.xml:
- Around line 42-53: The file now contains duplicate IssueNavigationLink entries
causing ambiguous navigation; locate the IssueNavigationLink blocks containing
option name="issueRegexp" with values "\(#(\d+)\)", "#(\d+)" and "GH-(\d+)" and
remove or replace the earlier/old duplicate blocks so only the intended mapping
to linkRegexp "https://github.com/aruaycodes/arkenv/issues/$1" remains for each
pattern; ensure each of the three regex patterns (\(#(\d+)\), #(\d+), GH-(\d+))
appears exactly once and points to the correct linkRegexp so there are no
multiple targets for the same issue token.

In `@apps/www/app/styles/theme/light.css`:
- Line 15: The muted foreground (--muted-foreground) is too light against
--background (`#fefefe`) and fails WCAG AA (~3.5:1); update the value of
--muted-foreground in the light theme so its contrast ratio is at least 4.5:1
against --background (and ensure the propagated --color-muted-foreground in
inline.css reflects this change), then verify the new HSL value visually and
with an automated contrast checker and commit the updated token.

---

Nitpick comments:
In `@apps/www/app/styles/theme/light.css`:
- Around line 10-11: The CSS defines --fd-primary and --color-fd-primary as
duplicate hex values which can drift from the main --primary; change both
--fd-primary and --color-fd-primary to alias the canonical token by setting them
to var(--primary) so they always inherit updates from --primary (update the
declarations for --fd-primary and --color-fd-primary to reference
var(--primary)).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f889407d-8f6d-4876-8ea7-7cb26f392ad6

📥 Commits

Reviewing files that changed from the base of the PR and between 9df72b4 and 1f9f6a0.

📒 Files selected for processing (3)
  • .idea/vcs.xml
  • apps/www/app/styles/theme/dark.css
  • apps/www/app/styles/theme/light.css

Comment thread .idea/vcs.xml
Comment on lines +42 to +53
<IssueNavigationLink>
<option name="issueRegexp" value="\(#(\d+)\)" />
<option name="linkRegexp" value="https://github.com/aruaycodes/arkenv/issues/$1" />
</IssueNavigationLink>
<IssueNavigationLink>
<option name="issueRegexp" value="#(\d+)" />
<option name="linkRegexp" value="https://github.com/aruaycodes/arkenv/issues/$1" />
</IssueNavigationLink>
<IssueNavigationLink>
<option name="issueRegexp" value="GH-(\d+)" />
<option name="linkRegexp" value="https://github.com/aruaycodes/arkenv/issues/$1" />
</IssueNavigationLink>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Replace the old issue links instead of adding a second set.

These new mappings duplicate the existing regexes, so #123 / GH-123 / (#123) now have multiple possible targets in the file. That makes issue navigation ambiguous and leaves the previous repo links active.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.idea/vcs.xml around lines 42 - 53, The file now contains duplicate
IssueNavigationLink entries causing ambiguous navigation; locate the
IssueNavigationLink blocks containing option name="issueRegexp" with values
"\(#(\d+)\)", "#(\d+)" and "GH-(\d+)" and remove or replace the earlier/old
duplicate blocks so only the intended mapping to linkRegexp
"https://github.com/aruaycodes/arkenv/issues/$1" remains for each pattern;
ensure each of the three regex patterns (\(#(\d+)\), #(\d+), GH-(\d+)) appears
exactly once and points to the correct linkRegexp so there are no multiple
targets for the same issue token.

Comment thread apps/www/app/styles/theme/light.css Outdated
@arkenv-bot
Copy link
Copy Markdown
Contributor

arkenv-bot Bot commented May 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (Asia/Almaty)
arkenv Ready Ready Preview, Comment May 2 2026, 1:35 PM (Asia/Almaty)

@yamcodes yamcodes merged commit c2b1de5 into main May 2, 2026
12 of 13 checks passed
@yamcodes yamcodes deleted the fix-hard-to-see-colors branch May 2, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

www Improvements or additions to arkenv.js.org

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant