Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to Pure Python if Compilation fails #76

Merged
merged 1 commit into from Sep 12, 2017

Conversation

@dstufft
Copy link
Contributor

@dstufft dstufft commented Sep 8, 2017

Originally this code attempted to determine if compiling the C ext
would succeed, and if it thought it should, it would then require that
the C extension succeed in order to install. This fails in cases where
the detection code passes, but compiling ultimately fails (one instance
this might happen is if the Python headers are not installed).

Instead of "asking permission", this code will now just attempt to
compile the module, and will fall back to pure Python if that fails,
unless the person has explicitly asked for the C module, in which case
it will still just fail.

Originally this code attempted to determine if compiling the C ext
would succeed, and if it thought it should, it would then require that
the C extension succeed in order to install. This fails in cases where
the detection code passes, but compiling ultimately fails (one instance
this might happen is if the Python headers are not installed).

Instead of "asking permission", this code will now just attempt to
compile the module, and will fall back to pure Python if that fails,
unless the person has explicitly asked for the C module, in which case
it will still just fail.
Copy link

@JordonPhillips JordonPhillips left a comment

Looks good to me. This is more or less what other libraries do, such as ruamel.yaml.

Loading

@sigmavirus24
Copy link
Contributor

@sigmavirus24 sigmavirus24 commented Sep 9, 2017

Less code is always better :D 👍

Loading

@sigmavirus24 sigmavirus24 merged commit 298e079 into yaml:master Sep 12, 2017
1 check passed
Loading
@wollerman
Copy link

@wollerman wollerman commented May 3, 2018

@sigmavirus24 is there going to be a release with these changes? 3.12 was released August 2016 and these changes are from September 2017. I was hoping to take advantage of the update :)

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants