Conversation
k-morozov
force-pushed
the
feature/database_migrate
branch
2 times, most recently
from
e8243c6 to
6c9b645
Compare
support migrate cluster
k-morozov
force-pushed
the
feature/database_migrate
branch
from
6c9b645 to
447b7b4
Compare
| mapping_table_to_metadata: dict, | ||
| ) -> None: | ||
| zk_db_path = f"/clickhouse/{metadata_non_repl_db.database_name}" | ||
| first_replica_database_name = zk_db_path + "/first_replica_database_name" |
There was a problem hiding this comment.
Write a comment what we do in this function. What is purpose of first_replica_database_name node ?
There was a problem hiding this comment.
Write a comment what we do in this function
Done
What is purpose of first_replica_database_name node ?
This is just a node as like replicas or metdata that we have to update. I think we don't need to describe the puroise of nodes: first_replica_database_name, metadata, replicas.
| ) | ||
|
|
||
| if match_str_ch_version(get_version(ctx), "25.1"): | ||
| metadata_path = CLICKHOUSE_PATH + "/" + metadata_path |
There was a problem hiding this comment.
What is specific in 25.1 ?
There was a problem hiding this comment.
Metdata path in 25.1 differs from previsous version. it doesn't contain full path.
| create_table_query = create_table_query.replace(migrating_database, temp_db) | ||
| logging.info("after replacing create_table_query=[{}]", create_table_query) | ||
|
|
||
| execute_query( |
There was a problem hiding this comment.
Actually, I'm worried about the order in which the tables are created. They could be dependent.
There was a problem hiding this comment.
I suggest checking this issue in the next PR.
2 participants
No description provided.