Feature: Change to Pydantic 2 compatible openapi schema parser #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change openapi-schema-pydantic for openapi-pydantic. openapi-pydantic is a fork of the previously used library, with support for both Pydantic 1 and 2.
yanyongyu
approved these changes
Aug 4, 2023
yanyongyu
changed the title
Owner
|
LGTM. We should change to campatible parser before we can bump pydantic to v2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've read through #38 and got excited to check and see what it would take to add support for Pydantic 2.
The first issue I encountered was that
openapi-schema-pydanticonly supports Pydantic 1, and hasn't been actively developed for a while. openapi-pydantic is a fork of openapi-schema-pydantic that has been updated with support for both Pydantic 1 and 2, and seems to be more actively maintained.I might be jumping the gun here, so if this is not the way that you've planned to tackle Pydantic2 support, feel free to close this PR.