fix(docs): repair migration link and mermaid label clipping#237
Merged
robertsLando merged 1 commit intomainfrom Apr 15, 2026
Merged
Conversation
- index.md: markdown link inside the fork-banner <div> was rendered as literal text because raw HTML blocks don't parse inline markdown without blank-line separation. Convert the block to use markdown content with surrounding blank lines so [migration guide] resolves. - custom.css: zero the default <p> margin inside mermaid nodeLabel / edgeLabel / cluster-label / label. Mermaid wraps label text in <p> via its markdown parser; the browser's default <p> margin inflated the rendered label height beyond the foreignObject size mermaid had pre-measured, clipping the last line below the node rect. - config.ts: set themeVariables.fontSize to 15px and add flowchart padding so mermaid's layout math matches the 15px rendered text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs-site/index.md: the[migration guide](/guide/migration)link inside<div class="fork-banner">was rendered as literal text because raw HTML blocks don't parse inline markdown without blank-line separation. The div now wraps blank-line-separated markdown content so the link resolves to/pkg/guide/migration.User code / fs.readFileSync / /snapshot/app/x.js,Executable with / custom VFS,Traditional / walker + bytecode). Mermaid renders label text through a markdown parser that wraps lines in<p>tags; the browser's default<p>margin inflated the rendered label height beyond theforeignObjectheight mermaid had pre-measured. Added CSS to zero<p>margins inside.nodeLabel / .edgeLabel / .cluster-label / .labeland normalizedline-height..vitepress/config.ts: setthemeVariables.fontSize: '15px'andflowchart.padding: 12so mermaid's layout math matches the 15px font-size applied bycustom.css.Test plan
npx vitepress buildsucceeds with no dead-link errors/pkg/architecturerender every label line inside its node box with no bottom clipping — both 2-line and 3-line labels🤖 Generated with Claude Code