fix(sea): strip trailing slashes in manifest key lookup#261
Merged
Conversation
SEA provider's toManifestKey did not strip trailing separators, so
fs.access('/snapshot/.../dist/') and similar calls missed manifest
keys (which are stored without trailing slashes) and threw ENOENT.
Classic (non-SEA) bootstrap already normalizes via
removeTrailingSlashes() in lib/common.ts — this brings SEA to parity.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toManifestKeydid not strip trailing separators, sofs.access('/snapshot/.../dist/')(and other APIs) missed manifest keys (stored without trailing slashes) and threwENOENT.removeTrailingSlashes()inlib/common.ts— this brings SEA to parity./to directory paths (e.g.nestjs-i18n).Fix
prelude/sea-vfs-setup.js: added a_stripTrailingSepshelper (root/preserved; handles/and\) and applied it insidetoManifestKeyon both POSIX and Windows paths.Test plan
test/test-89-sea-fs-opswith trailing-slash regression cases:existsSync,statSync,readdirSync,accessSync,fs.promises.access.yarn build && node test/test.js host no-npm test-89-sea-fs-ops— passes on Node 22.yarn lintclean.Fixes #260
🤖 Generated with Claude Code