fix(detector): pick up six more silent-drop shapes (re-exports, new URL, multi-arg path.join, path.resolve(__dirname,…), createRequire aliases, import.meta.resolve)

[robertsLando]

Summary

Follow-up to #268. Six more detector shapes that silently dropped their target — most visible in SEA mode where the ESM→CJS transform is skipped and the detector is the only dependency pass.

• ESM re-exports — export * from "lit", export { x } from "lit", export * as ns from "lit". visitorImport only matched ImportDeclaration; ExportAllDeclaration / ExportNamedDeclaration with .source now go through a parallel visitorReExport.
• new URL("./rel", import.meta.url) — canonical ESM sibling-asset idiom. Treated as ALIAS_AS_RELATIVE. Only matches when the base is literally import.meta.url so we don't synthesize paths from arbitrary URL bases.
• Multi-arg path.join(__dirname, "a", "b", …) and path.resolve(__dirname, "a", "b", …). Old code required exactly 2 args; now any literal-only segment list joins via path.posix.join to a single posix alias. Bails on non-literal segments to avoid guessing.
• path.resolve(__dirname, "lit") — same intent as path.join; also silences the spurious "ambiguous resolve" warning visitorUseSCWD used to emit for this exact shape (the call is now bundled, so the warning would contradict our own action).
• createRequire(import.meta.url)("./foo") (direct invocation) and const r = createRequire(...); r("./foo") (aliased form). detect() now pre-scans the AST for VariableDeclarator / AssignmentExpression bindings whose RHS is a createRequire(...) call, threads the bound names through the visitor as a 3rd arg, and visitorRequire / visitorRequireResolve treat them as require-equivalent.
• import.meta.resolve("lit") — modern ESM resolver API. Same ALIAS_AS_RESOLVABLE handling as require.resolve.

The issue's claim that require.resolve("lit", { paths: [...] }) silently drops was verified to be wrong — valid2(null) already accepts the ObjectExpression-as-2nd-arg case (because isLiteral(ObjectExpression) is false, v2 is set to null, and valid2(null) returns true), so existing code bundles the target correctly. No change there.

walker.ts forwards the new requireAliases Set from detect()'s visitor signature into visitorSuccessful so per-file alias state is applied.

Closes #269

Test plan

• yarn build, yarn lint — clean
• 12 new unit tests in test/unit/detector.test.ts covering every new shape (re-exports including named/namespace, multi-arg join/resolve, non-literal segment bail-out, new URL with non-import.meta.url base rejected, import.meta.resolve, direct + aliased createRequire, alias propagating to r.resolve, sanity check that unrelated identifiers don't get treated as require aliases, path.resolve(__dirname, …) no longer triggering visitorUseSCWD).
• Verified each test fails without the fix: stashed lib/detector.ts + lib/walker.ts → 12 failures, all and only the new tests. Restored → 211/211 pass.
• All pre-existing unit tests still pass.

🤖 Generated with Claude Code

[codecov]

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

[Copilot]

Pull request overview

This PR extends lib/detector.ts so the walker’s dependency detection (especially important in SEA mode) recognizes additional common ESM/Node patterns that previously resulted in silently dropped dependencies.

Changes:

• Add new detector matchers for ESM re-exports, new URL("./rel", import.meta.url), import.meta.resolve("..."), and improved path.join/resolve(__dirname, ...) handling (including multi-arg joins).
• Add a pre-scan for createRequire(...) aliases and thread the resulting requireAliases set through detection so aliased require calls can be recognized.
• Add unit tests covering the new shapes and update lib/walker.ts to forward the new alias context into visitorSuccessful.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
lib/detector.ts	Adds new AST matchers, createRequire alias pre-scan, and extends visitorSuccessful to use per-file requireAliases.
lib/walker.ts	Forwards requireAliases from detect() into visitorSuccessful so runtime behavior matches per-file alias state.
test/unit/detector.test.ts	Adds unit coverage for the new detector shapes and alias threading behavior.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

lib/detector.ts:538

• visitorPathJoin now matches both path.join and path.resolve, but the test printable form always renders as path.join(__dirname, ...), which is misleading for path.resolve cases and can make future unit tests/debug output inaccurate. Consider returning which method matched (join vs resolve) from visitorPathJoin and using it in the forge(...) pattern.

  if (was) {
    if (test) {
      return forge('path.join(__dirname{c1}{v1})', was);
    }