Fix FlashRL compatibility with vllm 0.10.2 and torch 2.8#36
Open
nightlessbaron wants to merge 3 commits intoyaof20:mainfrom
Open
Fix FlashRL compatibility with vllm 0.10.2 and torch 2.8#36nightlessbaron wants to merge 3 commits intoyaof20:mainfrom
nightlessbaron wants to merge 3 commits intoyaof20:mainfrom
Conversation
Author
|
I believe this should works now. Can you review it @LiyuanLucasLiu ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses critical compatibility issues with newer VLLM versions (0.10.2+) and PyTorch 2.8, ensuring FlashRL continues to work seamlessly with updated dependencies.
Changes Made
VLLM Parameter Attribute Compatibility (
flash_rl/vllm_patch.py)Issue: Parameter objects lost
tp_rankandtp_sizeattributes after PyTorch/VLLM upgrades.Fix: Added
tp_rankandtp_sizeto recorded_loader_keys list to ensure these critical distributed training attributes are preserved during model loading.Memory Pool Management (
flash_rl/fp8loader.py)Issue: VLLM memory pool API changes in newer versions
Fix: Updated memory pool context management to work with new PyTorch memory allocation APIs
Changes:
disable_mem_poolcontext manager to use new thread-local allocation APIs (_cuda_beginAllocateCurrentThreadToPool,_cuda_endAllocateToPool)