Skip to content

Create Challenge proposal #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2022
Merged

Create Challenge proposal #1

merged 1 commit into from
Sep 14, 2022

Conversation

@alinehaxkar
Copy link
Contributor

@alinehaxkar alinehaxkar commented Sep 9, 2022 •
edited
Loading

Describe your changes

Create a challenging interview to help improve our process.

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • All tests passed in a development environment
  • Linked card form board to PR (if applicable)
  • Applied proper tags to PR
  • Assigned PR for review

Test scenarios if applicable

@alinehaxkar alinehaxkar added the documentation Improvements or additions to documentation label Sep 9, 2022
@alinehaxkar alinehaxkar requested a review from lpessoa September 12, 2022 12:47
lmaucanirh
lmaucanirh reviewed Sep 12, 2022
View reviewed changes
lmaucanirh
lmaucanirh reviewed Sep 12, 2022
View reviewed changes
lmaucanirh
lmaucanirh reviewed Sep 12, 2022
View reviewed changes
lmaucanirh
lmaucanirh reviewed Sep 12, 2022
View reviewed changes
lmaucanirh
lmaucanirh reviewed Sep 12, 2022
View reviewed changes
lmaucanirh
lmaucanirh reviewed Sep 12, 2022
View reviewed changes
lmaucanirh
lmaucanirh reviewed Sep 12, 2022
View reviewed changes
lpessoa
lpessoa requested changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@lpessoa lpessoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tweaks 😉 and we are good to go

@alinehaxkar alinehaxkar force-pushed the feature/challenge branch 2 times, most recently from d32030d to eafac30 Compare September 12, 2022 16:19
lfventura
lfventura reviewed Sep 12, 2022
View reviewed changes
@lpessoa lpessoa merged commit 82817ab into main Sep 14, 2022
@lpessoa lpessoa deleted the feature/challenge branch September 14, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpessoa lpessoa lpessoa approved these changes

@lfventura lfventura Awaiting requested review from lfventura

+1 more reviewer

@lmaucanirh lmaucanirh lmaucanirh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alinehaxkar @lpessoa @lfventura @lmaucanirh