Skip to content

Conversation

@matuszsmig
Copy link
Contributor

No description provided.

@matuszsmig matuszsmig requested a review from grzanka October 15, 2024 21:18
@matuszsmig matuszsmig self-assigned this Oct 15, 2024
@matuszsmig matuszsmig linked an issue Oct 15, 2024 that may be closed by this pull request
@matuszsmig
Copy link
Contributor Author

@grzanka I would like to ask for some tips for this modal.
How to improve its look?
image

It appears just after clicking x on simulation, and deletes simulation when "yes" is being pressed.

@grzanka
Copy link
Contributor

grzanka commented Oct 16, 2024

Why don't you reuse this component ?
Screenshot 2024-10-16 at 15 09 51

See

export function LoadFileDialog({

and https://github.com/yaptide/ui/blob/6237216c527a8367af39aa44d4fcbe418165c356/src/ThreeEditor/components/Dialog/CustomDialog.tsx

Maybe Dialog will be good as well, instead of introducing new modal.

This way we maintain the same Look&Feel

@matuszsmig matuszsmig removed their assignment Oct 16, 2024
@matuszsmig
Copy link
Contributor Author

matuszsmig commented Oct 16, 2024

I have used Custom Dialog in my component and it looks like this:
image

Is it okay @grzanka ?

@grzanka
Copy link
Contributor

grzanka commented Oct 16, 2024

I have used Custom Dialog in my component and it looks like this: image

Is it okay @grzanka ?

Yes, looks better

@grzanka
Copy link
Contributor

grzanka commented Oct 16, 2024

@matuszsmig is it ready for tests ? if yes, then remove Draft status

@matuszsmig
Copy link
Contributor Author

@matuszsmig is it ready for tests ? if yes, then remove Draft status

yes it is

@matuszsmig matuszsmig marked this pull request as ready for review October 16, 2024 20:25
@grzanka grzanka added this pull request to the merge queue Oct 17, 2024
Merged via the queue into master with commit 91070bb Oct 17, 2024
@grzanka grzanka deleted the 1778-add-modal-for-delete branch October 17, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add modal for delete

3 participants