Fix for missing filters #1898
Merged
Fix for missing filters #1898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzanka
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
src/services/ShSimulatorService.tsxfile to introduce a new function for updating estimator references and integrate it into the existing workflow. The most important changes include the addition of therecreateRefToScoringManagerOutputsfunction and its usage within therecreateRefsInResultsfunction.New function addition:
src/services/ShSimulatorService.tsx: Added therecreateRefToScoringManagerOutputsfunction to update thescoringOutputJsonRefproperty of each estimator with the corresponding output from theScoringManagerJSON.Integration into existing workflow:
src/services/ShSimulatorService.tsx: Modified therecreateRefsInResultsfunction to use the newly addedrecreateRefToScoringManagerOutputsfunction before callingrecreateRefToFilters, ensuring that the estimators have updated scoring manager outputs.