Skip to content

Conversation

@jagodek
Copy link
Contributor

@jagodek jagodek commented Jan 4, 2025

Remake scoring output types.
This pull request includes several updates to the ThreeEditor module, focusing on improving the handling of scoring quantities and differential modifiers. The changes primarily involve updating method calls to include the current simulator context and refactoring code to use enums and utility functions for better maintainability.

Updates to Scoring Quantity Handling:

Refactoring and Code Simplification:

Sidebar Properties Enhancements:

Miscellaneous Updates:

@jagodek jagodek linked an issue Jan 4, 2025 that may be closed by this pull request
@jagodek jagodek requested a review from grzanka January 4, 2025 18:58
@jagodek
Copy link
Contributor Author

jagodek commented Jan 4, 2025

@grzanka. Here's initial idea of how such dictionary will look like

@jagodek jagodek self-assigned this Jan 4, 2025
@jagodek jagodek marked this pull request as ready for review January 6, 2025 15:52
@jagodek jagodek requested a review from grzanka January 6, 2025 15:54
@grzanka
Copy link
Contributor

grzanka commented Jan 7, 2025

@jagodek you can (squash)merge at will

@jagodek jagodek added this pull request to the merge queue Jan 7, 2025
Merged via the queue into master with commit 7ffcc6d Jan 7, 2025
8 checks passed
@jagodek jagodek deleted the 1931-remake-of-scoringoutputtypes branch January 7, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remake of ScoringOutputTypes

3 participants