-
Notifications
You must be signed in to change notification settings - Fork 5
Add filter display for Geant4 results & fix plot layout on smaller screens #2296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds functionality to display filter information in the Geant4 results view and improves the responsive layout for smaller screens. The filter information is fetched from either the project JSON (when available) or parsed from the input macro file, providing comprehensive filter display capabilities regardless of the input method.
Key changes:
- Parse filter information from Geant4 macro files and associate filters with scoring quantities
- Display filter details (name, type, rules, particles) alongside result graphs
- Implement responsive layout that adapts the results view for screens smaller than 1400px
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/services/Geant4ResultsFileParser.ts |
Added filter parsing from macro files, created filter reference generation logic, and integrated EditorJson support |
src/services/Geant4LocalWorkerSimulationService.ts |
Updated parser constructor to pass EditorJson and fixed conditional spread operator for inputJson |
src/ThreeEditor/Simulation/Scoring/GeantScoringFilter.ts |
Exported FilterType to enable usage in other modules |
src/JsRoot/GraphData.tsx |
Added responsive layout with filter display section and export button repositioning |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I get following error when browsing Geant4 example results: Screencast.from.2025-12-05.10-03-36.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This PR adds the ability to fetch filter information from either project JSON or input macro file and displays the information in the results view.
Additionally, it tries to make results look better on smaller screens.