Skip to content

Conversation

@kmichalikk
Copy link
Contributor

@kmichalikk kmichalikk commented Dec 4, 2025

This PR adds the ability to fetch filter information from either project JSON or input macro file and displays the information in the results view.
Additionally, it tries to make results look better on smaller screens.

results_small

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds functionality to display filter information in the Geant4 results view and improves the responsive layout for smaller screens. The filter information is fetched from either the project JSON (when available) or parsed from the input macro file, providing comprehensive filter display capabilities regardless of the input method.

Key changes:

  • Parse filter information from Geant4 macro files and associate filters with scoring quantities
  • Display filter details (name, type, rules, particles) alongside result graphs
  • Implement responsive layout that adapts the results view for screens smaller than 1400px

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
src/services/Geant4ResultsFileParser.ts Added filter parsing from macro files, created filter reference generation logic, and integrated EditorJson support
src/services/Geant4LocalWorkerSimulationService.ts Updated parser constructor to pass EditorJson and fixed conditional spread operator for inputJson
src/ThreeEditor/Simulation/Scoring/GeantScoringFilter.ts Exported FilterType to enable usage in other modules
src/JsRoot/GraphData.tsx Added responsive layout with filter display section and export button repositioning

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@grzanka
Copy link
Contributor

grzanka commented Dec 5, 2025

I get following error when browsing Geant4 example results:

Uncaught Error: Minified React error #300; visit https://react.dev/errors/300 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
    React 16
    onChange EstimatorsSelect.tsx:119
    onClick Tab.js:229
    React 11
    <anonymous> index.tsx:12
    <anonymous> index.tsx:23
    <anonymous> index.tsx:23
Screencast.from.2025-12-05.10-03-36.mp4

grzanka
grzanka previously approved these changes Dec 5, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kmichalikk kmichalikk enabled auto-merge December 5, 2025 19:26
@kmichalikk kmichalikk added this pull request to the merge queue Dec 5, 2025
Merged via the queue into master with commit 2bfefbc Dec 5, 2025
11 checks passed
@kmichalikk kmichalikk deleted the @kmichalikk/geant4-results-papercuts branch December 5, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants