fix import statement setup.py, required because entry_points is used#78
fix import statement setup.py, required because entry_points is used#78boegel wants to merge 1 commit intoyarden:fastmisofrom
Conversation
…e entry_points is used
|
Thank you so much for this, I'm looking into it. Seems like another reason why python packaging is a horrendous monstrosity. One thing I don't understand is why installation seems to work with Thanks, Yarden |
|
See https://pip.pypa.io/en/stable/reference/pip/#setuptools-injection PIP overrides distutils with setuptools. The reason this is important is that other build mechanisms (like EasyBuild) do not override, and currently the entry_points are missing from those builds. |
|
Also, install_requires is a setuptools directive and ignored by distutils, so builds finish successfully w/o dependencies. |
|
Thanks for this. The reason I haven't incorporated it yet (apart from lack of time) is that it's unclear to me whether setuptools's Extension is identical to distutils's -- and I am worried that they will behave differently with respect to building external libraries. Is there a known difference between the two or is it supposed to work? |
|
@yarden: setuptools is like distutils on steroids^2; it does a lot more, and is (in my experience) not to be trusted with being compatible with I'm afraid using |
|
This should be fixed now. |
See https://chriswarrick.com/blog/2014/09/15/python-apps-the-right-way-entry_points-and-scripts/
The key part on that page is "You must use setuptools, otherwise this won’t work."
Without this trivial patch, installing MISO using "python setup.py install" doesn't work, i.e. no scripts are being installed to the
binsubdirectory.