Skip to content

fix: document event delegation rather than querySelector for handler sharing#9

Merged
rivanuff merged 1 commit intomainfrom
fix/event-handler-selection
Dec 12, 2025
Merged

fix: document event delegation rather than querySelector for handler sharing#9
rivanuff merged 1 commit intomainfrom
fix/event-handler-selection

Conversation

@rivanuff
Copy link
Copy Markdown
Contributor

The GravityForms list field contains add and remove buttons which share the same event listener. This fix makes it so added list items their buttons also work.

image

@rivanuff rivanuff force-pushed the fix/event-handler-selection branch from c719ba4 to 54c0153 Compare December 12, 2025 10:39
@rivanuff rivanuff marked this pull request as ready for review December 12, 2025 10:40
@rivanuff rivanuff requested a review from a team as a code owner December 12, 2025 10:40
@rivanuff rivanuff force-pushed the fix/event-handler-selection branch from 54c0153 to d3861a1 Compare December 12, 2025 10:46
@rivanuff rivanuff changed the title fix: querySelector -> querySelectorAll fix: document event delegation rather than querySelector for handler sharing Dec 12, 2025
@rivanuff rivanuff force-pushed the fix/event-handler-selection branch from d3861a1 to 7ee1a6e Compare December 12, 2025 11:00
@rivanuff rivanuff merged commit 33e8ca5 into main Dec 12, 2025
@rivanuff rivanuff deleted the fix/event-handler-selection branch December 12, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants