Merged
Conversation
|
Coverage report for commit: c12050f Summary - Lines: 12.97% | Methods: 9.30%
🤖 comment via lucassabreu/comment-coverage-clover |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Composer package changes
|
SimonvanWijhe
requested review from
a team,
FreakyWizard,
WybeBosch,
YvetteNikolov,
colin-yard-nl,
dtakken,
ictbeheer,
laravdiemen,
mvdhoek1,
robertbossaert and
zoranaism
and removed request for
a team
mvdhoek1
approved these changes
Dec 2, 2024
| public function excerpt(int $count = 0): string | ||
| { | ||
| return get_the_excerpt($this->id); | ||
| if (0 === $count) { |
There was a problem hiding this comment.
1 > $count om ook negatieve waarden af te vangen?
Member
Author
There was a problem hiding this comment.
0 is de default waarde van $count. En hier wordt gecheck of $count gezet is.
There was a problem hiding this comment.
I know, hoe klein de kans ook is maar je kunt ook -1 meegeven aan de functie toch. Ook al gaat het nooit voorvallen is het wel goed om te checken. Mocht het wel ooit echt nodig zijn zit het in je systeem.
laravdiemen
approved these changes
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.