[Bug?]: Git 2.52.0 breaks git protocol

[adrianjappropo]

Self-service

• I'd be willing to implement a fix

Describe the bug

Using the latest Git for Windows release (git-for-windows/git#5959) causes an issue when running yarn install using Yarn 4.11.0 (but seemingly all versions of Yarn 4):

➤ YN0001: │ Repository URL: ssh://git@github.com/[private-org]/[private-repo].git
➤ YN0001: │ Error: invalid key: core.autocrlf
➤ YN0001: │ Fatal Error: unable to write parameters to config file
➤ YN0001: │ Exit Code: 128

I'm not sure if this is a Yarn issue or a Git issue but reporting it here anyway because that's where I encountered it.

To reproduce

Any package.json using the git protocol and using Git 2.52.0.

Environment

System:
    OS: Windows 11 10.0.26200
    CPU: (12) x64 AMD Ryzen 5 3600 6-Core Processor
  Binaries:
    Node: 22.21.0 - C:\Users\adria\AppData\Local\Temp\xfs-8f77040f\node.CMD
    Yarn: 4.11.0 - C:\Users\adria\AppData\Local\Temp\xfs-8f77040f\yarn.CMD
    npm: 10.9.4 - C:\Program Files\nodejs\npm.CMD
  npmPackages:
    jest: ^29.2.1 => 29.7.0

Additional context

No response

[adrianjappropo]

Rolling back to Git 2.51.2 (windows: https://github.com/git-for-windows/git/releases/tag/v2.51.2.windows.1) stops the issue from occurring, for people who need a fix right now

[Sharakai]

I'm getting the same issue on a Macbook with Git 2.52.0 (installed via Homebrew) and Yarn versions 4.10.3 & 4.11.0, so doesn't seem to be isolated to Git for Windows.

I can't see anything in the Git 2.52.0 release notes that is immediately obvious, and running git clone -c core.autocrlf <repo> works fine

[FPA-ChrisLaird]

Same issue on windows x64.

[mhassan1]

I see that the command that is run by Yarn has -c core.autocrlf=false in a single argument:

berry/packages/plugin-git/sources/gitUtils.ts

Line 262 in f4897aa

await git(`cloning the repository`, [`clone`, `-c core.autocrlf=false`, normalizedRepoUrl, npath.fromPortablePath(directory)], execOpts, {configuration, normalizedRepoUrl});

This will get executed as git clone "-c core.autocrlf=false" ..., which worked in previous versions of Git.

I'll put up a PR to fix this.