fix(git): split -c and core.autocrlf=false into separate args for clone
#6983
+26
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhassan1
force-pushed
the
fix-git-autocrlf-arg
branch
from
5cfdbff to
8f16246
Compare
bert-mccutchen
approved these changes
Nov 20, 2025
bert-mccutchen
left a comment
bert-mccutchen
left a comment
There was a problem hiding this comment.
Can confirm that this fixes the same issue that we are having after upgrading to Git 2.52.0.
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
This PR fixes a bug when calling
git clonewith Git 2.52.0; currently, Yarn is executinggit clone "-c core.autocrlf=false" ..., instead of the intendedgit clone -c core.autocrlf=false ..., and Git 2.52.0 does not like the quoted version.Resolves #6982.
How did you fix it?
This splits
-c core.autocrlf=falseinto separate arguments.Checklist