-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
docs(sdk): Add Emacs documentation and emit a typescript-language-server wrapper for (Emacs') LSP support #1129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
910f060 to
c07e7bc
Compare
| ))))) | ||
| ``` | ||
|
|
||
| 4. You may have to install `vscode-jsonrpc` and `vscode-languageserver-protocol` manually if `typescript-language-server` fails to start (they are not listed in its dependencies as of this writing): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to add those dependencies to the builtin packageExtensions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certainly! I'm pretty sure the experience becomes less confusing.
…ver wrapper for (Emacs') LSP support This also sorts SDK wrappers by name.
11f6e5f to
4866b1d
Compare
4866b1d to
c12e624
Compare
c12e624 to
25f1768
Compare
|
Perfect, thanks @martinjlowm ! |
|
@martinjlowm As far as I can tell |
|
** That is, dependencies aren't recognised even if I |
|
|
|
I migrated to LSP because I found Tide to be very slow :(. I don't know if that is still the case. Your setup looks correct, however, to see implementation details you would have to unplug specific dependencies. It's obviously not ideal and it would require a mapping of find-file to an implementation that supports the PnP interface. Do you know how/if Tide handles this properly? Type resolution itself should work out of the box, since it is the tsserver entry that resolves those and it's already wrapped for PnP. |
|
Yeah I'd rather LSP as it is faster but even with unplugged dependencies I can't seem to get LSP to find Tide is a little slow, although it is worth trying it with Had some success using Tide to jump to definition inside zipped buffer… ananthakumaran/tide#388 |
- "typescript": "^3.8.3"
+ "typescript": "^3.8.3",
+ "typescript-language-server": "^0.4.0"
+ },
+ "dependenciesMeta": {
+ "react": {
+ "unplugged": true
+ },
+ "react-dom": {
+ "unplugged": true
+ }Hmm LSP totally not picking up "react" still. |
|
Sorry, I forgot about this - I have just returned from a 2 week vacation... have you had any luck getting this to work? It sounds to me as if LSP still uses an unpatched typescript "entry", which does support resolving virtual paths in zip archives. looks good to me though 🤔 Unplugging is only necessary if you want to follow definitions. |
|
@martinjlowm same issue here, check #2049 |
This PR adds SDK documentation for Emacs which utilizes the generated binary wrappers for VS Code and supplies a new wrapper for https://github.com/theia-ide/typescript-language-server, enabling LSP support within Emacs.
Additionally, this also sorts SDK wrappers by name.