Fixes publishing scoped packages to third-party registries#439
Merged
Fixes publishing scoped packages to third-party registries#439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
When publishing a scoped package to a registry, we were sending a GET requested to the registry to determine whether the version there already existed (when using
--tolerate-republish). The problem is that we were doing this by passing the publish registry but not the ident, so our request was unauthenticated (and the GitHub Package Registry currently requires auth).I could have solved that by using
npmAlwaysAuth, but since the package was scoped the request should have been scoped anyway.How did you fix it?
I relaxed the rules in the
RegistryOptionsso that a registry may now be defined when an ident is explicitly provided (I didn't find the rational why I didn't implement it this way, although I suspect this was before we hadnpmPublishRegistry).