PnP: Stop using EDABF solution for Node 26.1.0+#7133
Merged
Conversation
Node 26.1.0 restored patchability of the `fs` module inside the loader pipeline, making our EBADF solution obsolete (for now) This commit stops applying our EBADF solution for Node 26.1.0+, to avoid triggering the "synthetic `require`" behavior which breaks some packages when our EBADF solution is applied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Node 26.1.0 restored patchability of the
fsmodule inside the loader pipeline, making our EBADF solution obsolete (for now)Our EBADF solution isn't "free" either. It triggers the "synthetic
require" behavior (where therequireglobal inside some CJS modules will only have some of the functionality, in particular it has norequire.cacheandrequire.extensionsproperties) which breaks some packages. It's just better than completely breaking when using affected Node versions.How did you fix it?
Stops applying our EBADF solution for Node 26.1.0+
Checklist