fix(shell): support redirection-only commands#7166
Open
StantonMatt wants to merge 1 commit into
Open
Conversation
StantonMatt
force-pushed
the
fix-shell-redirection-only
branch
from
717ae97 to
09d3716
Compare
Fixes yarnpkg#3986. Signed-off-by: Matthew Stanton <stantonmatthewj@gmail.com>
StantonMatt
force-pushed
the
fix-shell-redirection-only
branch
from
09d3716 to
dc5eb75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3986.
This teaches
@yarnpkg/shellto execute redirection-only command nodes directly instead of trying to spawn an undefined command name. It covers input/output/append redirection-only forms, subshell interpolation such as$(< file), env assignment with redirection, and pipeline shutdown cases where downstream commands stop reading early.Verification:
YARN_ENABLE_GLOBAL_CACHE=0 yarn test:unit packages/yarnpkg-shell/tests/shell.test.ts --runInBandYARN_ENABLE_GLOBAL_CACHE=0 yarn eslint packages/yarnpkg-shell/sources/index.ts packages/yarnpkg-shell/sources/pipe.ts packages/yarnpkg-shell/tests/shell.test.tsYARN_ENABLE_GLOBAL_CACHE=0 yarn typecheck:allYARN_ENABLE_GLOBAL_CACHE=0 yarn version checkgit diff --check