fix: explain peer-default dependencies in why#7168
Open
StantonMatt wants to merge 1 commit into
Open
Conversation
Signed-off-by: Matthew Stanton <stantonmatthewj@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7159.
yarn whycurrently skips any dependency whose ident is also listed inpeerDependencies, which hides real peer-with-default dependency edges. In the issue reproduction,@siteimprove/alfa-cypressdeclarescypressin bothdependenciesandpeerDependencies, soyarn why cypressreports nothing unless--peersis set.This keeps the default behavior of hiding injected virtual peer provisions, but no longer hides regular dependency edges just because the package also has a peer declaration for the same ident.
Verification:
TEST_BINARY=scripts/run-yarn.js node scripts/run-yarn.js workspace acceptance-tests test:integration packages/acceptance-tests/pkg-tests-specs/sources/commands/why.test.ts --runInBandYARN_IGNORE_PATH=1 node scripts/run-yarn.js why cypressin a clone ofSiteimprove/alfa-integrationsnow prints@siteimprove/alfa-cypress -> cypressYARN_IGNORE_PATH=1 node scripts/run-yarn.js why -R yauzlin the same clone now includes the Cypress branchnode scripts/run-yarn.js test:lintnode scripts/run-yarn.js typecheck:allnode scripts/run-yarn.js version checkgit diff --check