Skip to content

fix: resolve catalog workspace deps in foreach#7169

Open
StantonMatt wants to merge 1 commit into
yarnpkg:masterfrom
StantonMatt:stanton/fix-catalog-workspace-foreach-topological
Open

fix: resolve catalog workspace deps in foreach#7169
StantonMatt wants to merge 1 commit into
yarnpkg:masterfrom
StantonMatt:stanton/fix-catalog-workspace-foreach-topological

Conversation

@StantonMatt
Copy link
Copy Markdown

@StantonMatt StantonMatt commented Jun 3, 2026

What changed

  • Resolves workspaces foreach dependency graph checks through the normal dependency-reduction hooks before testing whether a dependency points at a workspace.
  • Applies that to recursive workspace selection and topological wait points, so named catalog entries that resolve to workspace:* are treated as workspace edges.
  • Adds acceptance coverage for catalog:local resolving to workspace:* with --recursive --topological-dev --from ... --exclude ....

Fixes #7129.

Verification

TEST_BINARY=$PWD/scripts/run-yarn.js node scripts/run-yarn.js jest --runTestsByPath packages/acceptance-tests/pkg-tests-specs/sources/commands/workspaces/foreach.test.js --runInBand
node scripts/run-yarn.js eslint --max-warnings 0 packages/plugin-workspace-tools/sources/commands/foreach.ts packages/acceptance-tests/pkg-tests-specs/sources/commands/workspaces/foreach.test.js
node scripts/run-yarn.js typecheck:all
node scripts/run-yarn.js test:lint
node scripts/run-yarn.js version check
git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug?]: If you set workspace:* in a catalog, topological-dev doesn't pick it up.

1 participant