Fix invalid fallback in bench-run.sh#7173
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the fallback branch in
scripts/bench-run.shso unknown package managers report a normal error instead of crashing with a bad shell substitution.Root cause
The default
casebranch used${$1}, which triggersbad substitutionin bash before the intended message can be printed. It also usedreturn 1even though this branch runs at script top level.Fix
${PACKAGE_MANAGER}in the error messageexit 1for the script-level failure pathVerification
bash -n scripts/bench-run.shbash scripts/bench-run.sh bogus gatsby /tmp/berry-bench-checknow printsInvalid package manager bogusand exits non-zero