Conversation
| your `.yarnrc`: | ||
|
|
||
| `$ yarn config set yarn-offline-mirror-pruning true` | ||
|
|
There was a problem hiding this comment.
Is it worth mentioning the version this feature was added in?
Actually, now that I look, there isn't yet a release or prerelease containing this, so having it already live on the docs page is sort of confusing. But anyway once there is a release, I think it could help to mention that this feature was introduced in that version.
The reason is that people using this feature would probably want to ensure everyone on their team is using at least that version, otherwise a team member with an old version of yarn could modify dependencies and the pruning wouldn't occur, which would then cause unrelated pruning for the next developer who modifies dependencies and is using a version that supports pruning (which is potentially confusing/annoying).
Personally I get around version mismatches like this by committing the bundled yarn executable into the repository and ensuring that team members are invoking that version (e.g. running bin/yarn rather than yarn). However, I know that many don't do this, and regardless I think it'd still be useful to mention the version that added pruning (once there's a release).
There was a problem hiding this comment.
Yeah, this is a good point. It didn't occur to me that the Yarn docs aren't versioned along with Yarn itself. @bestander, how do you want to handle this? We could add a message now saying that it will be in the next Yarn release, and then change it to the actual version when it happens.
There was a problem hiding this comment.
Currently we don't version the website, over time we will probably do it, the same way we do for React Native.
In our team we check in Yarn js bundle where it is important for all the team members to be on the same version.
I don't think it is a big deal for this feature as anyone changing dependencies after the team members with old Yarn would clean everything up.
Docs for yarnpkg/yarn#2836. @bestander said we can convert the blog post later.