Skip to content

Add some offline mirror docs#409

Merged
bestander merged 1 commit intoyarnpkg:masterfrom
dguo:offline-mirror
Mar 8, 2017
Merged

Add some offline mirror docs#409
bestander merged 1 commit intoyarnpkg:masterfrom
dguo:offline-mirror

Conversation

@dguo
Copy link
Copy Markdown
Contributor

@dguo dguo commented Mar 8, 2017

Docs for yarnpkg/yarn#2836. @bestander said we can convert the blog post later.

@dguo dguo force-pushed the offline-mirror branch from b8ec2e8 to ff4d142 Compare March 8, 2017 06:33
@bestander bestander merged commit 755fb50 into yarnpkg:master Mar 8, 2017
@dguo dguo deleted the offline-mirror branch March 8, 2017 14:35
your `.yarnrc`:

`$ yarn config set yarn-offline-mirror-pruning true`

Copy link
Copy Markdown

@rmacklin rmacklin Mar 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth mentioning the version this feature was added in?

Actually, now that I look, there isn't yet a release or prerelease containing this, so having it already live on the docs page is sort of confusing. But anyway once there is a release, I think it could help to mention that this feature was introduced in that version.

The reason is that people using this feature would probably want to ensure everyone on their team is using at least that version, otherwise a team member with an old version of yarn could modify dependencies and the pruning wouldn't occur, which would then cause unrelated pruning for the next developer who modifies dependencies and is using a version that supports pruning (which is potentially confusing/annoying).

Personally I get around version mismatches like this by committing the bundled yarn executable into the repository and ensuring that team members are invoking that version (e.g. running bin/yarn rather than yarn). However, I know that many don't do this, and regardless I think it'd still be useful to mention the version that added pruning (once there's a release).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is a good point. It didn't occur to me that the Yarn docs aren't versioned along with Yarn itself. @bestander, how do you want to handle this? We could add a message now saying that it will be in the next Yarn release, and then change it to the actual version when it happens.

Copy link
Copy Markdown
Member

@bestander bestander Mar 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we don't version the website, over time we will probably do it, the same way we do for React Native.

In our team we check in Yarn js bundle where it is important for all the team members to be on the same version.

I don't think it is a big deal for this feature as anyone changing dependencies after the team members with old Yarn would clean everything up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants