Fix platform dependent compilation for OSX#96
Merged
yasirkula merged 1 commit intoyasirkula:masterfrom Mar 31, 2024
Merged
Conversation
Contributor
Author
Owner
|
I think your fix is still valid because as you've demonstrated, the plugin doesn't work properly when target platform isn't set to macOS in OSX editor. |
Contributor
Author
On macOS, we want the code blocks take effect in the Editor, regardless of the chosen build target. So in addition to `UNITY_STANDALONE_OSX`, we also have to check for `UNITY_EDITOR_OSX`. And on Windows, we don't want these code blocks to take effect in the Editor, even though macOS has been selected as the build target. So we only should check for `UNITY_STANDALONE_OSX` when not running in the Editor.
6c18980 to
de66d97
Compare
Contributor
Author
|
@yasirkula |
Owner
|
Awesome! I got sick this week, hence the delay 😞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




There are code blocks wrapped by
UNITY_STANDALONE_OSXto only work on OSX.But to make them also work in the Unity Editor on macOS, a check for
UNITY_EDITOR_OSXneeds to be added as well.1. Filter quick link section from too many macOS drives
Before
After
2. Documents quick link should lead into actual
~/DocumentsfolderBefore
After
3. Add user folder to quick link section