Skip to content

generateYCPWrappers: check also for YCPNull to avoid segfault#64

Merged
lslezak merged 1 commit intoopenSUSE-13_1from
missing_parameters
Oct 22, 2013
Merged

generateYCPWrappers: check also for YCPNull to avoid segfault#64
lslezak merged 1 commit intoopenSUSE-13_1from
missing_parameters

Conversation

@lslezak
Copy link
Copy Markdown
Member

@lslezak lslezak commented Oct 21, 2013

when a parameter is missing (bnc#846467)

  • 3.0.3

when a parameter is missing (bnc#846467)

- 3.0.3
@lslezak
Copy link
Copy Markdown
Member Author

lslezak commented Oct 21, 2013

This is a generic fix for https://bugzilla.novell.com/show_bug.cgi?id=846467 instead of yast/yast-pkg-bindings#12

@jreidinger
Copy link
Copy Markdown
Member

LGTM

@mvidner
Copy link
Copy Markdown
Member

mvidner commented Oct 21, 2013

So this fix can be tested only in a dependent package (pkg-bindings, ...) that actually uses the header generator. The added isNull check looks safe enough but please do test it to rule out check for accidental typso.

@lslezak
Copy link
Copy Markdown
Member Author

lslezak commented Oct 22, 2013

Yes, I have checked it in pkg-binding, works as expected.

lslezak added a commit that referenced this pull request Oct 22, 2013
generateYCPWrappers: check also for YCPNull to avoid segfault
@lslezak lslezak merged commit a834ced into openSUSE-13_1 Oct 22, 2013
@lslezak lslezak deleted the missing_parameters branch October 22, 2013 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants