Skip to content

Conversation

@lslezak
Copy link
Member

@lslezak lslezak commented Oct 24, 2014

No description provided.

@jreidinger
Copy link
Member

LGTM

jreidinger added a commit that referenced this pull request Oct 30, 2014
@jreidinger jreidinger merged commit a80e61a into master Oct 30, 2014
@jreidinger jreidinger deleted the Travis branch October 30, 2014 15:00
noelpower added a commit to noelpower/yast-python-bindings that referenced this pull request May 5, 2022
e.g. examples/Table1.py

has

            Table(
              Header(
                "\u00C4nerhe\u00DF",
                "\u00C4\u00DF\u00F6\u00F6\u00E4\u00E4\u00E4\u00E4\u00E4"
              ),
              [
                Item(
                  Id('1'),
                  "\u011B\u0161\u010D\u0159\u017E\u00FD\u00E1\u00ED\u02C7",
                  6
                ),
=>              Item(Id(2), "\u011B\u0161\u0159\u017E", None),
                Item(Id(3), "\u00C4nder\u00DF\u00DF\u00DF", 8),

where the value of the TableItem is passed None, this results in the
following core

(gdb) where

 #0  YCPValueRep::isTerm() const (this=0x0) at YCPValue.cc:70
 yast#1  0x00007ffff48c1974 in YCPTableItemParser::parseTableItem(YCPTerm const&) (itemTerm=...) at YCPTableItemParser.cc:117
 yast#2  0x00007ffff48c13e0 in YCPTableItemParser::parseTableItemList(YCPList const&) (itemList=...) at YCPTableItemParser.cc:60
 yast#3  0x00007ffff489ad44 in YCPDialogParser::parseTable(YWidget*, YWidgetOpt&, YCPTerm const&, YCPList const&, int) (parent=parent@entry=0x7fffe840ee30, opt=..., term=..., optList=..., argnr=0) at YCPDialogParser.cc:2604
 yast#4  0x00007ffff48b151d in YCPDialogParser::parseWidgetTreeTerm(YWidget*, YWidgetOpt&, YCPTerm const&) (p=p@entry=0x7fffe840ee30, opt=..., term=...) at YCPDialogParser.cc:311
 yast#5  0x00007ffff48b1c9a in YCPDialogParser::parseWidgetTreeTerm(YWidget*, YCPTerm const&) (parent=parent@entry=0x7fffe840ee30, term=...) at YCPDialogParser.cc:413
 yast#6  0x00007ffff48b373a in YCPDialogParser::parseMinSize(YWidget*, YWidgetOpt&, YCPTerm const&, YCPList const&, int, bool, bool) (parent=parent@entry=0x7fffe831eab0, opt=..., term=..., optList=..., argnr=<optimized out>, hor=<optimized out>, vert=true) at YCPDialogParser.cc:713

so it appears the correct translation for Py_None is YCP_Void()
rather than YCP_Null()

Signed-off-by: Noel Power <noel.power@suse.com>
noelpower added a commit to noelpower/yast-python-bindings that referenced this pull request May 6, 2022
e.g. examples/Table1.py

has

            Table(
              Header(
                "\u00C4nerhe\u00DF",
                "\u00C4\u00DF\u00F6\u00F6\u00E4\u00E4\u00E4\u00E4\u00E4"
              ),
              [
                Item(
                  Id('1'),
                  "\u011B\u0161\u010D\u0159\u017E\u00FD\u00E1\u00ED\u02C7",
                  6
                ),
=>              Item(Id(2), "\u011B\u0161\u0159\u017E", None),
                Item(Id(3), "\u00C4nder\u00DF\u00DF\u00DF", 8),

where the value of the TableItem is passed None, this results in the
following core

(gdb) where

 #0  YCPValueRep::isTerm() const (this=0x0) at YCPValue.cc:70
 yast#1  0x00007ffff48c1974 in YCPTableItemParser::parseTableItem(YCPTerm const&) (itemTerm=...) at YCPTableItemParser.cc:117
 yast#2  0x00007ffff48c13e0 in YCPTableItemParser::parseTableItemList(YCPList const&) (itemList=...) at YCPTableItemParser.cc:60
 yast#3  0x00007ffff489ad44 in YCPDialogParser::parseTable(YWidget*, YWidgetOpt&, YCPTerm const&, YCPList const&, int) (parent=parent@entry=0x7fffe840ee30, opt=..., term=..., optList=..., argnr=0) at YCPDialogParser.cc:2604
 yast#4  0x00007ffff48b151d in YCPDialogParser::parseWidgetTreeTerm(YWidget*, YWidgetOpt&, YCPTerm const&) (p=p@entry=0x7fffe840ee30, opt=..., term=...) at YCPDialogParser.cc:311
 yast#5  0x00007ffff48b1c9a in YCPDialogParser::parseWidgetTreeTerm(YWidget*, YCPTerm const&) (parent=parent@entry=0x7fffe840ee30, term=...) at YCPDialogParser.cc:413
 yast#6  0x00007ffff48b373a in YCPDialogParser::parseMinSize(YWidget*, YWidgetOpt&, YCPTerm const&, YCPList const&, int, bool, bool) (parent=parent@entry=0x7fffe831eab0, opt=..., term=..., optList=..., argnr=<optimized out>, hor=<optimized out>, vert=true) at YCPDialogParser.cc:713

so it appears the correct translation for Py_None is YCP_Void()
rather than YCP_Null()

Signed-off-by: Noel Power <noel.power@suse.com>
noelpower added a commit to noelpower/yast-python-bindings that referenced this pull request May 9, 2022
e.g. examples/Table1.py

has

            Table(
              Header(
                "\u00C4nerhe\u00DF",
                "\u00C4\u00DF\u00F6\u00F6\u00E4\u00E4\u00E4\u00E4\u00E4"
              ),
              [
                Item(
                  Id('1'),
                  "\u011B\u0161\u010D\u0159\u017E\u00FD\u00E1\u00ED\u02C7",
                  6
                ),
=>              Item(Id(2), "\u011B\u0161\u0159\u017E", None),
                Item(Id(3), "\u00C4nder\u00DF\u00DF\u00DF", 8),

where the value of the TableItem is passed None, this results in the
following core

(gdb) where

 #0  YCPValueRep::isTerm() const (this=0x0) at YCPValue.cc:70
 yast#1  0x00007ffff48c1974 in YCPTableItemParser::parseTableItem(YCPTerm const&) (itemTerm=...) at YCPTableItemParser.cc:117
 yast#2  0x00007ffff48c13e0 in YCPTableItemParser::parseTableItemList(YCPList const&) (itemList=...) at YCPTableItemParser.cc:60
 yast#3  0x00007ffff489ad44 in YCPDialogParser::parseTable(YWidget*, YWidgetOpt&, YCPTerm const&, YCPList const&, int) (parent=parent@entry=0x7fffe840ee30, opt=..., term=..., optList=..., argnr=0) at YCPDialogParser.cc:2604
 yast#4  0x00007ffff48b151d in YCPDialogParser::parseWidgetTreeTerm(YWidget*, YWidgetOpt&, YCPTerm const&) (p=p@entry=0x7fffe840ee30, opt=..., term=...) at YCPDialogParser.cc:311
 yast#5  0x00007ffff48b1c9a in YCPDialogParser::parseWidgetTreeTerm(YWidget*, YCPTerm const&) (parent=parent@entry=0x7fffe840ee30, term=...) at YCPDialogParser.cc:413
 yast#6  0x00007ffff48b373a in YCPDialogParser::parseMinSize(YWidget*, YWidgetOpt&, YCPTerm const&, YCPList const&, int, bool, bool) (parent=parent@entry=0x7fffe831eab0, opt=..., term=..., optList=..., argnr=<optimized out>, hor=<optimized out>, vert=true) at YCPDialogParser.cc:713

so it appears the correct translation for Py_None is YCP_Void()
rather than YCP_Null()

Signed-off-by: Noel Power <noel.power@suse.com>
noelpower added a commit to noelpower/yast-python-bindings that referenced this pull request Jun 22, 2022
e.g. examples/Table1.py

has

            Table(
              Header(
                "\u00C4nerhe\u00DF",
                "\u00C4\u00DF\u00F6\u00F6\u00E4\u00E4\u00E4\u00E4\u00E4"
              ),
              [
                Item(
                  Id('1'),
                  "\u011B\u0161\u010D\u0159\u017E\u00FD\u00E1\u00ED\u02C7",
                  6
                ),
=>              Item(Id(2), "\u011B\u0161\u0159\u017E", None),
                Item(Id(3), "\u00C4nder\u00DF\u00DF\u00DF", 8),

where the value of the TableItem is passed None, this results in the
following core

(gdb) where

 #0  YCPValueRep::isTerm() const (this=0x0) at YCPValue.cc:70
 yast#1  0x00007ffff48c1974 in YCPTableItemParser::parseTableItem(YCPTerm const&) (itemTerm=...) at YCPTableItemParser.cc:117
 yast#2  0x00007ffff48c13e0 in YCPTableItemParser::parseTableItemList(YCPList const&) (itemList=...) at YCPTableItemParser.cc:60
 yast#3  0x00007ffff489ad44 in YCPDialogParser::parseTable(YWidget*, YWidgetOpt&, YCPTerm const&, YCPList const&, int) (parent=parent@entry=0x7fffe840ee30, opt=..., term=..., optList=..., argnr=0) at YCPDialogParser.cc:2604
 yast#4  0x00007ffff48b151d in YCPDialogParser::parseWidgetTreeTerm(YWidget*, YWidgetOpt&, YCPTerm const&) (p=p@entry=0x7fffe840ee30, opt=..., term=...) at YCPDialogParser.cc:311
 yast#5  0x00007ffff48b1c9a in YCPDialogParser::parseWidgetTreeTerm(YWidget*, YCPTerm const&) (parent=parent@entry=0x7fffe840ee30, term=...) at YCPDialogParser.cc:413
 yast#6  0x00007ffff48b373a in YCPDialogParser::parseMinSize(YWidget*, YWidgetOpt&, YCPTerm const&, YCPList const&, int, bool, bool) (parent=parent@entry=0x7fffe831eab0, opt=..., term=..., optList=..., argnr=<optimized out>, hor=<optimized out>, vert=true) at YCPDialogParser.cc:713

so it appears the correct translation for Py_None is YCP_Void()
rather than YCP_Null()

Signed-off-by: Noel Power <noel.power@suse.com>
noelpower added a commit to noelpower/yast-python-bindings that referenced this pull request Feb 8, 2023
e.g. examples/Table1.py

has

            Table(
              Header(
                "\u00C4nerhe\u00DF",
                "\u00C4\u00DF\u00F6\u00F6\u00E4\u00E4\u00E4\u00E4\u00E4"
              ),
              [
                Item(
                  Id('1'),
                  "\u011B\u0161\u010D\u0159\u017E\u00FD\u00E1\u00ED\u02C7",
                  6
                ),
=>              Item(Id(2), "\u011B\u0161\u0159\u017E", None),
                Item(Id(3), "\u00C4nder\u00DF\u00DF\u00DF", 8),

where the value of the TableItem is passed None, this results in the
following core

(gdb) where

 #0  YCPValueRep::isTerm() const (this=0x0) at YCPValue.cc:70
 yast#1  0x00007ffff48c1974 in YCPTableItemParser::parseTableItem(YCPTerm const&) (itemTerm=...) at YCPTableItemParser.cc:117
 yast#2  0x00007ffff48c13e0 in YCPTableItemParser::parseTableItemList(YCPList const&) (itemList=...) at YCPTableItemParser.cc:60
 yast#3  0x00007ffff489ad44 in YCPDialogParser::parseTable(YWidget*, YWidgetOpt&, YCPTerm const&, YCPList const&, int) (parent=parent@entry=0x7fffe840ee30, opt=..., term=..., optList=..., argnr=0) at YCPDialogParser.cc:2604
 yast#4  0x00007ffff48b151d in YCPDialogParser::parseWidgetTreeTerm(YWidget*, YWidgetOpt&, YCPTerm const&) (p=p@entry=0x7fffe840ee30, opt=..., term=...) at YCPDialogParser.cc:311
 yast#5  0x00007ffff48b1c9a in YCPDialogParser::parseWidgetTreeTerm(YWidget*, YCPTerm const&) (parent=parent@entry=0x7fffe840ee30, term=...) at YCPDialogParser.cc:413
 yast#6  0x00007ffff48b373a in YCPDialogParser::parseMinSize(YWidget*, YWidgetOpt&, YCPTerm const&, YCPList const&, int, bool, bool) (parent=parent@entry=0x7fffe831eab0, opt=..., term=..., optList=..., argnr=<optimized out>, hor=<optimized out>, vert=true) at YCPDialogParser.cc:713

so it appears the correct translation for Py_None is YCP_Void()
rather than YCP_Null()

Signed-off-by: Noel Power <noel.power@suse.com>
noelpower added a commit to noelpower/yast-python-bindings that referenced this pull request Feb 8, 2023
e.g. examples/Table1.py

has

            Table(
              Header(
                "\u00C4nerhe\u00DF",
                "\u00C4\u00DF\u00F6\u00F6\u00E4\u00E4\u00E4\u00E4\u00E4"
              ),
              [
                Item(
                  Id('1'),
                  "\u011B\u0161\u010D\u0159\u017E\u00FD\u00E1\u00ED\u02C7",
                  6
                ),
=>              Item(Id(2), "\u011B\u0161\u0159\u017E", None),
                Item(Id(3), "\u00C4nder\u00DF\u00DF\u00DF", 8),

where the value of the TableItem is passed None, this results in the
following core

(gdb) where

 #0  YCPValueRep::isTerm() const (this=0x0) at YCPValue.cc:70
 yast#1  0x00007ffff48c1974 in YCPTableItemParser::parseTableItem(YCPTerm const&) (itemTerm=...) at YCPTableItemParser.cc:117
 yast#2  0x00007ffff48c13e0 in YCPTableItemParser::parseTableItemList(YCPList const&) (itemList=...) at YCPTableItemParser.cc:60
 yast#3  0x00007ffff489ad44 in YCPDialogParser::parseTable(YWidget*, YWidgetOpt&, YCPTerm const&, YCPList const&, int) (parent=parent@entry=0x7fffe840ee30, opt=..., term=..., optList=..., argnr=0) at YCPDialogParser.cc:2604
 yast#4  0x00007ffff48b151d in YCPDialogParser::parseWidgetTreeTerm(YWidget*, YWidgetOpt&, YCPTerm const&) (p=p@entry=0x7fffe840ee30, opt=..., term=...) at YCPDialogParser.cc:311
 yast#5  0x00007ffff48b1c9a in YCPDialogParser::parseWidgetTreeTerm(YWidget*, YCPTerm const&) (parent=parent@entry=0x7fffe840ee30, term=...) at YCPDialogParser.cc:413
 yast#6  0x00007ffff48b373a in YCPDialogParser::parseMinSize(YWidget*, YWidgetOpt&, YCPTerm const&, YCPList const&, int, bool, bool) (parent=parent@entry=0x7fffe831eab0, opt=..., term=..., optList=..., argnr=<optimized out>, hor=<optimized out>, vert=true) at YCPDialogParser.cc:713

so it appears the correct translation for Py_None is YCP_Void()
rather than YCP_Null()

Signed-off-by: Noel Power <noel.power@suse.com>
noelpower added a commit to noelpower/yast-python-bindings that referenced this pull request Feb 8, 2023
e.g. examples/Table1.py

has

            Table(
              Header(
                "\u00C4nerhe\u00DF",
                "\u00C4\u00DF\u00F6\u00F6\u00E4\u00E4\u00E4\u00E4\u00E4"
              ),
              [
                Item(
                  Id('1'),
                  "\u011B\u0161\u010D\u0159\u017E\u00FD\u00E1\u00ED\u02C7",
                  6
                ),
=>              Item(Id(2), "\u011B\u0161\u0159\u017E", None),
                Item(Id(3), "\u00C4nder\u00DF\u00DF\u00DF", 8),

where the value of the TableItem is passed None, this results in the
following core

(gdb) where

 #0  YCPValueRep::isTerm() const (this=0x0) at YCPValue.cc:70
 yast#1  0x00007ffff48c1974 in YCPTableItemParser::parseTableItem(YCPTerm const&) (itemTerm=...) at YCPTableItemParser.cc:117
 yast#2  0x00007ffff48c13e0 in YCPTableItemParser::parseTableItemList(YCPList const&) (itemList=...) at YCPTableItemParser.cc:60
 yast#3  0x00007ffff489ad44 in YCPDialogParser::parseTable(YWidget*, YWidgetOpt&, YCPTerm const&, YCPList const&, int) (parent=parent@entry=0x7fffe840ee30, opt=..., term=..., optList=..., argnr=0) at YCPDialogParser.cc:2604
 yast#4  0x00007ffff48b151d in YCPDialogParser::parseWidgetTreeTerm(YWidget*, YWidgetOpt&, YCPTerm const&) (p=p@entry=0x7fffe840ee30, opt=..., term=...) at YCPDialogParser.cc:311
 yast#5  0x00007ffff48b1c9a in YCPDialogParser::parseWidgetTreeTerm(YWidget*, YCPTerm const&) (parent=parent@entry=0x7fffe840ee30, term=...) at YCPDialogParser.cc:413
 yast#6  0x00007ffff48b373a in YCPDialogParser::parseMinSize(YWidget*, YWidgetOpt&, YCPTerm const&, YCPList const&, int, bool, bool) (parent=parent@entry=0x7fffe831eab0, opt=..., term=..., optList=..., argnr=<optimized out>, hor=<optimized out>, vert=true) at YCPDialogParser.cc:713

so it appears the correct translation for Py_None is YCP_Void()
rather than YCP_Null()

Signed-off-by: Noel Power <noel.power@suse.com>
noelpower added a commit to noelpower/yast-python-bindings that referenced this pull request Feb 8, 2023
e.g. examples/Table1.py

has

            Table(
              Header(
                "\u00C4nerhe\u00DF",
                "\u00C4\u00DF\u00F6\u00F6\u00E4\u00E4\u00E4\u00E4\u00E4"
              ),
              [
                Item(
                  Id('1'),
                  "\u011B\u0161\u010D\u0159\u017E\u00FD\u00E1\u00ED\u02C7",
                  6
                ),
=>              Item(Id(2), "\u011B\u0161\u0159\u017E", None),
                Item(Id(3), "\u00C4nder\u00DF\u00DF\u00DF", 8),

where the value of the TableItem is passed None, this results in the
following core

(gdb) where

 #0  YCPValueRep::isTerm() const (this=0x0) at YCPValue.cc:70
 yast#1  0x00007ffff48c1974 in YCPTableItemParser::parseTableItem(YCPTerm const&) (itemTerm=...) at YCPTableItemParser.cc:117
 yast#2  0x00007ffff48c13e0 in YCPTableItemParser::parseTableItemList(YCPList const&) (itemList=...) at YCPTableItemParser.cc:60
 yast#3  0x00007ffff489ad44 in YCPDialogParser::parseTable(YWidget*, YWidgetOpt&, YCPTerm const&, YCPList const&, int) (parent=parent@entry=0x7fffe840ee30, opt=..., term=..., optList=..., argnr=0) at YCPDialogParser.cc:2604
 yast#4  0x00007ffff48b151d in YCPDialogParser::parseWidgetTreeTerm(YWidget*, YWidgetOpt&, YCPTerm const&) (p=p@entry=0x7fffe840ee30, opt=..., term=...) at YCPDialogParser.cc:311
 yast#5  0x00007ffff48b1c9a in YCPDialogParser::parseWidgetTreeTerm(YWidget*, YCPTerm const&) (parent=parent@entry=0x7fffe840ee30, term=...) at YCPDialogParser.cc:413
 yast#6  0x00007ffff48b373a in YCPDialogParser::parseMinSize(YWidget*, YWidgetOpt&, YCPTerm const&, YCPList const&, int, bool, bool) (parent=parent@entry=0x7fffe831eab0, opt=..., term=..., optList=..., argnr=<optimized out>, hor=<optimized out>, vert=true) at YCPDialogParser.cc:713

so it appears the correct translation for Py_None is YCP_Void()
rather than YCP_Null()

Signed-off-by: Noel Power <noel.power@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants