Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/import_generation.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
24
25
2 changes: 1 addition & 1 deletion .github/last_commit.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
110937321b45fb3be9ca39ff3bb83bcdfcf52c97
b39a359f04c57875ea162524646ae879f06c7a33
2 changes: 2 additions & 0 deletions include/ydb-cpp-sdk/client/monitoring/monitoring.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ enum class EStatusFlag {

struct TSelfCheckSettings : public TOperationRequestSettings<TSelfCheckSettings>{
FLUENT_SETTING_OPTIONAL(bool, ReturnVerboseStatus);
FLUENT_SETTING_OPTIONAL(bool, NoMerge);
FLUENT_SETTING_OPTIONAL(bool, NoCache);
FLUENT_SETTING_OPTIONAL(EStatusFlag, MinimumStatus);
FLUENT_SETTING_OPTIONAL(uint32_t, MaximumLevel);
};
Expand Down
3 changes: 3 additions & 0 deletions src/api/protos/ydb_topic.proto
Original file line number Diff line number Diff line change
Expand Up @@ -475,6 +475,9 @@ message StreamReadMessage {

// Write timestamp of next message written to this partition will be no less than write_time_high_watermark.
google.protobuf.Timestamp write_time_high_watermark = 4;

// Messages with offsets up to and including (read_offset - 1) was read.
int64 read_offset = 5;
}

// Command from server to create and start a partition session.
Expand Down
8 changes: 8 additions & 0 deletions src/client/monitoring/monitoring.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,14 @@ class TMonitoringClient::TImpl : public TClientImplCommon<TMonitoringClient::TIm
request.set_return_verbose_status(settings.ReturnVerboseStatus_.value());
}

if (settings.NoMerge_) {
request.set_merge_records(!settings.NoMerge_.value());
}

if (settings.NoCache_) {
request.set_do_not_cache(settings.NoCache_.value());
}

if (settings.MinimumStatus_) {
request.set_minimum_status((::Ydb::Monitoring::StatusFlag_Status)settings.MinimumStatus_.value());
}
Expand Down
2 changes: 1 addition & 1 deletion src/client/topic/impl/read_session_impl.ipp
Original file line number Diff line number Diff line change
Expand Up @@ -1701,7 +1701,7 @@ inline void TSingleClusterReadSessionImpl<false>::OnReadDoneImpl(
bool pushRes = EventsQueue->PushEvent(partitionStreamIt->second,
TReadSessionEvent::TPartitionSessionStatusEvent(
partitionStreamIt->second, msg.committed_offset(),
0, // TODO: support read offset in status
msg.read_offset(),
msg.partition_offsets().end(),
TInstant::MilliSeconds(::google::protobuf::util::TimeUtil::TimestampToMilliseconds(
msg.write_time_high_watermark()))),
Expand Down
Loading