fix(schema): use one cache entree for tenant path schemas #1016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
requested changes
Jul 15, 2024
| const schemaLoading = schemaIsFetching && schemaData === undefined; | ||
|
|
||
| const keyColumnsIds = schemaData?.PathDescription?.Table?.KeyColumnNames; | ||
| const keyColumnsIds = schemaData?.[path]?.PathDescription?.Table?.KeyColumnNames; |
There was a problem hiding this comment.
Schema tab displays nothing
Comment on lines
+64
to
+66
| serializeQueryArgs: ({queryArgs: {path}}) => { | ||
| const parts = path.split('/'); | ||
| return {path: parts[0] || parts[1]}; |
There was a problem hiding this comment.
How does this serialize works? Data is cached for the tenant?
artemmufazalov
requested changes
Jul 16, 2024
Comment on lines
+37
to
+50
| do { | ||
| const promise = dispatch( | ||
| schemaApi.endpoints.getSchema.initiate({path}, {forceRefetch: true}), | ||
| ); | ||
| const {data, originalArgs} = await promise; | ||
| promise.unsubscribe(); | ||
| // Check if the result from the current request is received. rtk-query may skip the current request and | ||
| // return data from a parallel request, due to the same cache key. | ||
| if (originalArgs?.path === path) { | ||
| schemaData = data?.[path]; | ||
| break; | ||
| } | ||
| // eslint-disable-next-line no-constant-condition | ||
| } while (true); |
There was a problem hiding this comment.
Why to do this in do while cycle? await is not enough?
There was a problem hiding this comment.
As described in the comment, the "promise" may return result from another request (with another params), so we try to repeat the request in this case.
artemmufazalov
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1014