Skip to content

fix: better retry timeout for traces #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix: better retry timeout for traces #1263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/services/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,16 @@ import {
SECOND_IN_MS,
} from '../utils/constants';
import {prepareSortValue} from '../utils/filters';
import {isAxiosError} from '../utils/response';
import type {Nullable} from '../utils/typecheckers';

import {parseMetaCluster} from './parsers/parseMetaCluster';
import {parseMetaTenants} from './parsers/parseMetaTenants';
import {settingsManager} from './settings';

// Overall timeout 53~71 s depending on server response time
const TRACE_CHECK_TIMEOUT = 2 * SECOND_IN_MS;
const MAX_TRACE_CHECK_RETRIES = 9;
const TRACE_API_ERROR_TIMEOUT = 10 * SECOND_IN_MS;
const MAX_TRACE_CHECK_RETRIES = 30;

type AxiosOptions = {
concurrentId?: string;
Expand Down Expand Up @@ -570,7 +571,17 @@ export class YdbEmbeddedAPI extends AxiosWrapper {
timeout: TRACE_CHECK_TIMEOUT,
'axios-retry': {
retries: MAX_TRACE_CHECK_RETRIES,
retryDelay: axiosRetry.exponentialDelay,
retryDelay: (_: number, error: unknown) => {
const isTracingError =
isAxiosError(error) &&
(error?.response?.status === 404 || error.code === 'ERR_NETWORK');

if (isTracingError) {
return TRACE_CHECK_TIMEOUT;
}

return TRACE_API_ERROR_TIMEOUT;
},
shouldResetTimeout: true,
retryCondition: () => true,
},
Expand Down