Skip to content

fix(TabletsTable): action icons coincide in tablet's page and in table #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix(TabletsTable): action icons coincide in tablet's page and in table #1549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/components/ButtonWithConfirmDialog/ButtonWithConfirmDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ interface ButtonWithConfirmDialogProps<T, K> {
retryButtonText?: string;
buttonDisabled?: ButtonProps['disabled'];
buttonView?: ButtonProps['view'];
buttonTitle?: ButtonProps['title'];
buttonClassName?: ButtonProps['className'];
withPopover?: boolean;
popoverContent?: PopoverProps['content'];
Expand All @@ -31,6 +32,7 @@ export function ButtonWithConfirmDialog<T, K>({
retryButtonText,
buttonDisabled = false,
buttonView = 'action',
buttonTitle,
buttonClassName,
withPopover = false,
popoverContent,
Expand Down Expand Up @@ -69,6 +71,7 @@ export function ButtonWithConfirmDialog<T, K>({
disabled={buttonDisabled}
loading={!buttonDisabled && buttonLoading}
className={buttonClassName}
title={buttonTitle}
>
{children}
</Button>
Expand Down
5 changes: 3 additions & 2 deletions src/containers/Tablets/TabletsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {ArrowsRotateRight} from '@gravity-ui/icons';
import {ArrowRotateLeft} from '@gravity-ui/icons';
import type {Column as DataTableColumn} from '@gravity-ui/react-data-table';
import {Icon, Text} from '@gravity-ui/uikit';

Expand Down Expand Up @@ -128,6 +128,7 @@ function TabletActions(tablet: TTabletStateInfo) {
return (
<ButtonWithConfirmDialog
buttonView="outlined"
buttonTitle={i18n('dialog.kill-header')}
dialogHeader={i18n('dialog.kill-header')}
dialogText={i18n('dialog.kill-text')}
onConfirmAction={() => {
Expand All @@ -138,7 +139,7 @@ function TabletActions(tablet: TTabletStateInfo) {
popoverContent={i18n('controls.kill-not-allowed')}
popoverDisabled={isUserAllowedToMakeChanges}
>
<Icon data={ArrowsRotateRight} />
<Icon data={ArrowRotateLeft} />
</ButtonWithConfirmDialog>
);
}
Expand Down
Loading