Skip to content

fix(ClusterOverview): loading state #2250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025
Merged

fix(ClusterOverview): loading state #2250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/containers/Cluster/ClusterOverview/ClusterOverview.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,4 +67,9 @@
min-width: 280px;
height: 132px;
}

&__card_collapsed {
min-width: 120px;
height: 28px;
}
}
2 changes: 1 addition & 1 deletion src/containers/Cluster/ClusterOverview/ClusterOverview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ function ClusterDashboard({collapsed, ...props}: ClusterDashboardProps) {

function ClusterDoughnuts({cluster, groupStats = {}, loading, collapsed}: ClusterOverviewProps) {
if (loading) {
return <ClusterDashboardSkeleton />;
return <ClusterDashboardSkeleton collapsed={collapsed} />;
}
const metricsCards = [];
if (isClusterInfoV2(cluster)) {
Expand Down
24 changes: 16 additions & 8 deletions src/containers/Cluster/ClusterOverview/components/ClusterMetricsCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,13 @@ interface ClusterMetricsCommonCardProps {
collapsed?: boolean;
}

export function ClusterMetricsCard({children, className}: ClusterMetricsCommonCardProps) {
export function ClusterMetricsCard({
children,
className,
collapsed,
}: ClusterMetricsCommonCardProps) {
return (
<Flex gap="6" alignItems="center" className={b('card', className)}>
<Flex gap="6" alignItems="center" className={b('card', {collapsed}, className)}>
{children}
</Flex>
);
Expand Down Expand Up @@ -70,20 +74,24 @@ export function ClusterMetricsCardContent({
);
}

function ClusterMetricsCardSkeleton() {
interface ClusterMetricsCardSkeletonProps {
collapsed?: boolean;
}

function ClusterMetricsCardSkeleton({collapsed}: ClusterMetricsCardSkeletonProps) {
return (
<ClusterMetricsCard className={b('skeleton-wrapper')}>
<ClusterMetricsCard className={b('skeleton-wrapper')} collapsed={collapsed}>
<Skeleton className={b('skeleton')} />
</ClusterMetricsCard>
);
}

export function ClusterDashboardSkeleton() {
export function ClusterDashboardSkeleton({collapsed}: ClusterMetricsCardSkeletonProps) {
return (
<React.Fragment>
<ClusterMetricsCardSkeleton />
<ClusterMetricsCardSkeleton />
<ClusterMetricsCardSkeleton />
<ClusterMetricsCardSkeleton collapsed={collapsed} />
<ClusterMetricsCardSkeleton collapsed={collapsed} />
<ClusterMetricsCardSkeleton collapsed={collapsed} />
</React.Fragment>
);
}
Loading