feat: dont fetch render for false graphshard

[astandrik]

Closes #2801

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total	Passed	Failed	Flaky	Skipped
378	373	0	3	2

Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 85.38 MB | Main: 85.38 MB
Diff: +0.95 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information

• Test recordings for failed tests are available in the full report.
• Bundle size is measured for the entire 'dist' directory.
• 📊 indicates links to detailed reports.
• 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

[astandrik]

/claude_review

[claude]

Claude finished @astandrik's task —— View job

---

Code Review for PR #2803: Don't fetch render for false graphshard

Review Checklist

• Read modified files and understand changes
• Check TypeScript type safety and interfaces
• Verify React best practices and performance patterns
• Check API call patterns (window.api usage)
• Verify i18n usage for user-facing text
• Check error handling and loading states
• Provide comprehensive review feedback

Summary

This PR improves performance by preventing unnecessary chart data fetches when the GraphShard capability is explicitly false. The changes are well-implemented and follow the codebase standards.

✅ Strengths

1. Performance Optimization: Properly skips API calls when graphShardExists === false, avoiding unnecessary network requests (src/components/QueriesActivityBar/useQueriesActivityData.ts:33-34, 54, 64)

2. Type Safety: All TypeScript types are properly maintained with no changes to interfaces

3. React Best Practices:

   • Proper use of useMemo for derived values (lines 70-81, 83-91, 93-111)
   • Correct dependency arrays in all hooks
   • No unnecessary re-renders

4. Redux/RTK Query Pattern: Correctly uses the skip option in RTK Query hooks to conditionally fetch data

5. Clean Implementation: The changes are minimal and focused on the specific issue

📋 Observations

1. Consistent Pattern: Both files implement the same pattern of checking graphShardExists === false before rendering/fetching

2. Backward Compatibility: The implementation maintains backward compatibility with a three-state logic:

   • null/undefined: Still loading or capability not available
   • true: GraphShard exists, proceed with fetching
   • false: GraphShard explicitly doesn't exist, skip operations

3. No User-Facing Text: No new user-facing strings were added, so no i18n issues

4. API Usage: All API calls properly go through window.api as required

🎯 No Issues Found

The implementation is clean, follows all project standards, and achieves the performance optimization goal without introducing any issues.

Performance Impact

The changes will reduce unnecessary API calls and improve performance for clusters without GraphShard capability, which aligns with the issue #2801 requirements.

[Copilot]

Pull Request Overview

This PR optimizes chart rendering behavior by preventing unnecessary data fetching when GraphShard capability is explicitly disabled. The change improves performance by avoiding API calls for chart data when the system knows charts won't be functional.

Key Changes

• Early return in TenantDashboard when GraphShard is explicitly false
• Skip chart data fetching in QueriesActivityBar when GraphShard is disabled
• Update comment formatting from JSDoc link to regular markdown link

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
TenantDashboard.tsx	Adds early return when GraphShard is explicitly false and updates comment formatting
useQueriesActivityData.ts	Adds GraphShard capability check to skip chart API calls when disabled

[Copilot]

The comment format has been changed from JSDoc @link to plain markdown. This breaks JSDoc documentation parsing. Consider reverting to @link https://github.com/ydb-platform/ydb-embedded-ui/issues/659 to maintain proper JSDoc formatting.

Suggested change

	* Link: https://github.com/ydb-platform/ydb-embedded-ui/issues/659
	* @link https://github.com/ydb-platform/ydb-embedded-ui/issues/659