Skip to content

Conversation

@artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Sep 4, 2025

Stand: https://nda.ya.ru/t/QoyjGhCZ7JVcow

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
378 370 0 6 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 85.39 MB | Main: 85.39 MB
Diff: +1.28 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the visual spacing and organization of the Healthcheck issue details interface. The changes increase gap spacing throughout the component hierarchy to provide better visual separation and extract location-related components into a dedicated module.

Key changes:

  • Increased gap spacing from 2 to 3 in most components and from 3 to 4 in the main issues container
  • Extracted node and peer location components into a new IssueLocation component for better code organization
  • Updated CSS custom properties to align with the new spacing values

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
utils.tsx Increased default gap from 2 to 3 in SectionWithTitle component
StorageLocation.tsx Updated gap spacing from 2 to 3 in the storage location flex container
IssueLocation.tsx New component that consolidates storage, compute, node, and peer location rendering
HealthcheckIssueDetails.tsx Refactored to use the new IssueLocation component, removing duplicated location components
ComputeLocation.tsx Updated gap spacing from 2 to 3 in the compute location flex container
Healthcheck.tsx Increased main container gap from 3 to 4 for better visual separation
Healthcheck.scss Updated CSS custom property for definition list item gap from spacing-2 to spacing-3

@artemmufazalov artemmufazalov marked this pull request as ready for review September 4, 2025 15:31
@artemmufazalov artemmufazalov added this pull request to the merge queue Sep 5, 2025
Merged via the queue into main with commit c81a708 Sep 5, 2025
7 checks passed
@artemmufazalov artemmufazalov deleted the issue-location branch September 5, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants