Skip to content

Conversation

@DaryaVorontsova
Copy link
Contributor

@DaryaVorontsova DaryaVorontsova commented Oct 31, 2025

#1379
Stand

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
378 372 0 4 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 47.09 MB | Main: 47.08 MB
Diff: +2.13 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Oct 31, 2025

Skipped: This PR does not contain any of your configured keywords: (greptile-review)


const handleTextFilterChange = (value: string) => {
setQueryParams({search: value || undefined}, 'replaceIn');
useEffect(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great that you've thought about this!

@@ -1,3 +1,5 @@
import {useEffect} from 'react';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have lost linter rule about imports from react. Could you please fix this to import React from 'react'? I'll tune linter config!

@DaryaVorontsova DaryaVorontsova added this pull request to the merge queue Oct 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 31, 2025
@DaryaVorontsova DaryaVorontsova added this pull request to the merge queue Nov 1, 2025
Merged via the queue into main with commit 74d6d5d Nov 1, 2025
7 checks passed
@DaryaVorontsova DaryaVorontsova deleted the fix/storage-split-search branch November 1, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Storage] Do not save search when switching between groups and nodes

3 participants